Skip to content

mgr: include cleanup#61607

Merged
idryomov merged 15 commits intoceph:mainfrom
MaxKellermann:mgr_includes
Feb 11, 2025
Merged

mgr: include cleanup#61607
idryomov merged 15 commits intoceph:mainfrom
MaxKellermann:mgr_includes

Conversation

@MaxKellermann
Copy link
Member

@MaxKellermann MaxKellermann commented Jan 31, 2025

Another PR split from #60490; this time the "mgr" subsystem.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@MaxKellermann MaxKellermann requested a review from a team as a code owner January 31, 2025 11:17
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Jan 31, 2025

CI completely b0rked.

java.nio.file.AccessDeniedException: /home/jenkins-build/build/workspace/ceph-pull-requests

@MaxKellermann MaxKellermann mentioned this pull request Feb 6, 2025
Merged
14 tasks
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Feb 6, 2025

@batrick please merge this PR before #61608 as it contains important fixes required for the other PR.

@MaxKellermann
mgr/Mgr: add missing include
ae5aadf 
Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
mgr/ClusterState: move own header to the top
327b3de 
This allows verifying the header's dependencies.

Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
mgr/MDSPerfMetricTypes.h: use <iosfwd>
64b77fb 
Reduce header bloat a bit.

Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
mgr/ServiceMap: add missing includes
0f367a5 
Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
mgr/MgrCap: add missing includes
4f1f40a 
Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
mgr/MgrOpRequest: add missing includes
5c70e38 
Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
mgr/DaemonState: add missing includes
2d2982e 
Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
mgr/BaseMgrStandbyModule: add missing include
55c2f49 
Signed-off-by: Max Kellermann <[email protected]>
idryomov
idryomov reviewed Feb 7, 2025
View reviewed changes
@idryomov
Copy link
Contributor

idryomov commented Feb 7, 2025

jenkins test api

@idryomov
Copy link
Contributor

idryomov commented Feb 10, 2025

jenkins test windows

@idryomov
Copy link
Contributor

idryomov commented Feb 10, 2025

jenkins test make check arm64

@idryomov
Copy link
Contributor

idryomov commented Feb 11, 2025

jenkins test api

1 similar comment
@idryomov
Copy link
Contributor

idryomov commented Feb 11, 2025

jenkins test api

@idryomov idryomov merged commit 4bfea6b into ceph:main Feb 11, 2025
12 checks passed
@MaxKellermann MaxKellermann deleted the mgr_includes branch February 12, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idryomov idryomov idryomov approved these changes

Assignees

No one assigned

Labels

core mgr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxKellermann @idryomov