rgw: handle destination bucket as an ARN in ReplicationConfiguration#61421
Merged
rgw: handle destination bucket as an ARN in ReplicationConfiguration#61421
Conversation
49c1efe to
5629f18
Compare
adamemerson
approved these changes
Jan 17, 2025
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
The S3 ReplicationConfiguration's destination bucket must be treated as an ARN, per the AWS S3 documentation: https://docs.aws.amazon.com/AmazonS3/latest/API/API_Destination.html#AmazonS3-Type-Destination-Bucket Fixes: https://tracker.ceph.com/issues/69568 Signed-off-by: Seena Fallah <[email protected]>
5629f18 to
b8f8932
Compare
Member
Author
|
jenkins retest this please |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The S3 ReplicationConfiguration's destination bucket must be treated as an ARN, per the AWS S3 documentation:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_Destination.html#AmazonS3-Type-Destination-Bucket
Fixes: https://tracker.ceph.com/issues/69568