os/bluestore: Add health warning for bluestore fragmentation#61214
Merged
os/bluestore: Add health warning for bluestore fragmentation#61214
Conversation
ifed01
reviewed
Jan 10, 2025
src/os/bluestore/BlueStore.cc
Outdated
| auto now = mono_clock::now(); | ||
| timespan elapsed = now - last_fragmentation_check; | ||
| if (elapsed > make_timespan(period)) { | ||
| double score = store->alloc->get_fragmentation_score(); |
Contributor
There was a problem hiding this comment.
Can we log at pretty low level (0?) before and after this call to be able to identify relevant stalls if any.
aclamk
force-pushed
the
wip-aclamk-bs-fragmentation-health
branch
from
8921afc to
a98cef0
Compare
Contributor
Author
|
jenkins test make check |
Contributor
Author
Contributor
Author
|
jenkins test api |
ifed01
approved these changes
Feb 7, 2025
src/os/bluestore/BlueStore.cc
Outdated
| if (elapsed > make_timespan(period)) { | ||
| last_fragmentation_check = now; | ||
| double score = 0; | ||
| if (store->alloc) { |
Contributor
There was a problem hiding this comment.
may be do above along with "period !=0" check:
if (period != 0 && store->alloc)
...
Contributor
Author
|
jenkins test api |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
aclamk
force-pushed
the
wip-aclamk-bs-fragmentation-health
branch
from
0c7c174 to
1861330
Compare
Changed "bluestore/fragmentation_micros" from quick imprecise to slow but more representative score. Introduced config "bluestore_warn_on_free_fragmentation" that controls when free space fragmentation score becomes a health warning. Currently calculation of fragmentation score might be non-instant for severly fragmented disks. It might induce stalls to write IO. Config value "bluestore_fragmentation_check_period" control score calculation period. In future, costly score calculation will be replaced with method that continously updates score. Signed-off-by: Adam Kupczyk <[email protected]>
Using fmt::format requires libfmt for linking Signed-off-by: Adam Kupczyk <[email protected]>
aclamk
force-pushed
the
wip-aclamk-bs-fragmentation-health
branch
from
1861330 to
3c5ae6c
Compare
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
[ FAILED ] TestLibRBD.TestPendingAio |
Contributor
Author
|
jenkins test api |
Member
|
jenkins test make check |
Member
|
make check failure unrelated |
Member
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
14 tasks
| last_fragmentation_check = now; | ||
| double score; | ||
| score = store->alloc->get_fragmentation_score(); | ||
| store->logger->set(l_bluestore_fragmentation, score * 1e6); |
Contributor
There was a problem hiding this comment.
@aclamk Was it intentional to make the fragmentation score a thousand times larger than before?
Prior to the PR, the fragmentation score returned by the ceph_bluestore_fragmentation_micros metric was simply multiplied by 1000, and documented as such:
How fragmented bluestore free space is (free extents / max possible number of free extents) * 1000
But now it's being multiplied by 1e6, making it hard to create consistent dashboards and alerts for both Reef and Squid clusters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed "bluestore/fragmentation_micros" from quick imprecise to slow but more representative score.
Introduced config "bluestore_warn_on_free_fragmentation" that controls when free space fragmentation score becomes a health warning.
Currently calculation of fragmentation score might be non-instant for severly fragmented disks. It might induce stalls to write IO. Config value "bluestore_fragmentation_check_period" control score calculation period.
In future, costly score calculation will be replaced with method that continously updates score.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e