squid: osd/scrub: register for 'osd_max_scrubs' config changes#61185
Merged
ronen-fr merged 1 commit intoceph:squidfrom Jan 7, 2025
Merged
squid: osd/scrub: register for 'osd_max_scrubs' config changes#61185ronen-fr merged 1 commit intoceph:squidfrom
ronen-fr merged 1 commit intoceph:squidfrom
Conversation
Since ceph#55340, the osd_max_scrubs (also) affects the parameters of the async scrub reserver used by the replicas. Thus, the code must notice and acknowledge changes to this config. Fixes: https://tracker.ceph.com/issues/69362 Signed-off-by: Ronen Friedman <[email protected]> (cherry picked from commit 31e6bac)
athanatos
approved these changes
Jan 2, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #55340, the osd_max_scrubs (also) affects the parameters of the async scrub reserver used by the replicas. Thus,
the code must notice and acknowledge changes to this config.
Backport of #61184.
Original tracker: https://tracker.ceph.com/issues/69362
Backport tracker: https://tracker.ceph.com/issues/69374
(cherry picked from commit 31e6bac)