fcopyfile() reads 1 MiB of data every time but when a fragment smaller
than 1 MiB is left, it still reads 1 MiB of data, causing to never meet
the condition of "off == size". This leads to an infinity loop which
continues to write until CephFS becomes full.

Resolves: rhbz#2379716
Fixes: https://tracker.ceph.com/issues/72238
Signed-off-by: Rishabh Dave <[email protected]>

Signed-off-by: Rishabh Dave <[email protected]>

Move "directory empty" logic to new method "_is_empty_directory".
Future logic will not be a one-liner, so let's keep it separate.

Resolves: rhbz#2376757
Signed-off-by: Marcus Watts <[email protected]>
(cherry picked from commit f0cf85a595876165e2c0eb2ca584e97f44971f9d)

Better check for empty direcotry.
It turns out in->dirstat contains a count of files and subdirectories
from a directory, so all we have to do is make sure that's valid.

Resolves: rhbz#2376757
Signed-off-by: Marcus Watts <[email protected]>
(cherry picked from commit ba233f2dda3cf30c67b653b065e9ed47d42cb9d6)

After each fscrypt unit test clean up after each
unit test.

Signed-off-by: Christopher Hoffman <[email protected]>

Add fscrypt dummy encryption to client. This will allow
for mounting a cephfs volume without providing any fscrypt
information. This will allow for more straightforward setup
for development and test suites.

Signed-off-by: Christopher Hoffman <[email protected]>

Signed-off-by: Christopher Hoffman <[email protected]>

Signed-off-by: Christopher Hoffman <[email protected]>

Fix warnings/errors in ceph API tests that are present in FSCrypt.cc

src/client/FSCrypt.cc:90:6: error: variable 'olen' set but not used [-Werror,-Wunused-but-set-variable]
   90 |         int olen = 0;
      |             ^
src/client/FSCrypt.cc:91:6: error: variable 'line' set but not used [-Werror,-Wunused-but-set-variable]
   91 |         int line = 0;
      |             ^
src/client/FSCrypt.cc:945:2: error: is this the way to do it? [-Werror,-W#warnings]
  945 | #warning is this the way to do it?

Signed-off-by: Christopher Hoffman <[email protected]>

Fix warnings/errors in ceph API tests that are present in various files
that were introduced by fscrypt feature

src/client/FSCrypt.cc:90:6: error: variable 'olen' set but not used [-Werror,-Wunused-but-set-variable]
   90 |         int olen = 0;
      |             ^
src/client/FSCrypt.cc:91:6: error: variable 'line' set but not used [-Werror,-Wunused-but-set-variable]
   91 |         int line = 0;
      |             ^
src/client/FSCrypt.cc:945:2: error: is this the way to do it? [-Werror,-W#warnings]
  945 | #warning is this the way to do it?
src/client/Client.cc:11850:2: error: read holes [-Werror,-W#warnings]
 11850 | #warning read holes
       |  ^
src/client/Client.cc:11855:2: error: implement file read here [-Werror,-W#warnings]
 11855 | #warning implement file read here
       |  ^
src/client/Inode.cc:847:2: error: need to make sure that we do not skip entire subtree somehow [-Werror,-W#warnings]
  847 | #warning need to make sure that we do not skip entire subtree somehow
      |  ^

Signed-off-by: Christopher Hoffman <[email protected]>

When calling get encryption policy via ioctl, do not display
the hex str of inbuf. This buffer is not used/uninitialized
so no need to display.

Signed-off-by: Christopher Hoffman <[email protected]>

Signed-off-by: Christopher Hoffman <[email protected]>

ALL caps are now needed for when setting fscrypt policy

Signed-off-by: Christopher Hoffman <[email protected]>

The libcephfs API call add_fscrypt_key exposes an internal fscrypt
data structure. This is because a hash keyid (of the master key) is used
for calls such as remove_fscrypt_key. Instead of using this structure,
use a char array to obtain keyid.

Fixes: https://tracker.ceph.com/issues/63293
Signed-off-by: Christopher Hoffman <[email protected]>

Once a volume/filesystem is set to use fscrypt encryption, layout
cannot be changed. The configurable ec_profile, sets layout and
will fail.

Fixes: https://tracker.ceph.com/issues/73461
Signed-off-by: Christopher Hoffman <[email protected]>

A max io size can currently be up to INT_MAX. If it is greater,
then clamp the size to INT_MAX. This conflicts with fscrypt io
operations. An fscrypt, op needs to read a whole fscrypt block.
The size of fscrypt block size is 4K, INT_MAX % 4K is not equal
to 0. Therefore, get the nearest multiple of 4K to INT_MAX that
does not go over. In the fscrypt case, this value will be used
for clamping max io size.

Fixes: https://tracker.ceph.com/issues/73346
Signed-off-by: Christopher Hoffman <[email protected]>

When testing large io sizes and clamping that io, consider
fscrypt max io size. This max io size should be a multiple
of 4K (fscrypt block size), but not to exceed INT_MAX.

Signed-off-by: Christopher Hoffman <[email protected]>

The commit 154b867 reverted part of the fix seen in 2b74598.
This commit will reapply any missing changes of the fix.

Fixes: https://tracker.ceph.com/issues/73416
Signed-off-by: Christopher Hoffman <[email protected]>

Fix various python bindings and linting issues that
arose from libcephfs fscrypt testing in pipeline.

Signed-off-by: Christopher Hoffman <[email protected]>

Do not build client with fscrypt on non-linux distros.

Fixes: https://tracker.ceph.com/issues/70324
Signed-off-by: Christopher Hoffman <[email protected]>

Signed-off-by: Christopher Hoffman <[email protected]>