Skip to content

Comments

tools/kvstore_tool: add missing #ifdef WITH_BLUESTORE#61020

Merged
neha-ojha merged 2 commits intoceph:mainfrom
MaxKellermann:kvstore_tool__ifdef_WITH_BLUESTORE
Jul 15, 2025
Merged

tools/kvstore_tool: add missing #ifdef WITH_BLUESTORE#61020
neha-ojha merged 2 commits intoceph:mainfrom
MaxKellermann:kvstore_tool__ifdef_WITH_BLUESTORE

Conversation

@MaxKellermann
Copy link
Member

@MaxKellermann MaxKellermann commented Dec 10, 2024 •
edited by batrick
Loading

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

@github-actions github-actions bot added the core label Dec 10, 2024
ifed01
ifed01 reviewed Dec 16, 2024
View reviewed changes
@rzarzynski rzarzynski requested a review from aclamk December 16, 2024 23:40
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Jan 13, 2025

@aclamk, will you approve this PR?

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Jan 13, 2025

Can one of the admins verify this patch?

@MaxKellermann MaxKellermann mentioned this pull request Feb 7, 2025
Merged
14 tasks
@MaxKellermann MaxKellermann force-pushed the kvstore_tool__ifdef_WITH_BLUESTORE branch from 3247b86 to ebd1452 Compare February 19, 2025 07:34
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Feb 19, 2025

@aclamk?

ifed01
ifed01 reviewed Feb 19, 2025
View reviewed changes
@MaxKellermann
tools/kvstore_tool: make load_bluestore() private
71d5e90 
This method is only used internally.

Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann
tools/kvstore_tool: add missing #ifdef WITH_BLUESTORE
3ead485 
Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann MaxKellermann force-pushed the kvstore_tool__ifdef_WITH_BLUESTORE branch from ebd1452 to 3ead485 Compare February 21, 2025 14:53
@github-actions
Copy link

github-actions bot commented Apr 22, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Apr 22, 2025
@ifed01
Copy link
Contributor

ifed01 commented Apr 22, 2025

jenkins test make check arm64

@github-actions github-actions bot removed the stale label Apr 22, 2025
@MaxKellermann
Copy link
Member Author

MaxKellermann commented May 20, 2025

jenkins test make check arm64

@batrick batrick changed the title tools/kvstore_tool: add missing #ifdef WITH_BLUESTORE tools/kvstore_tool: add missing #ifdef WITH_BLUESTORE May 22, 2025
@batrick batrick changed the title tools/kvstore_tool: add missing #ifdef WITH_BLUESTORE tools/kvstore_tool: add missing #ifdef WITH_BLUESTORE May 22, 2025
@sseshasa
Copy link
Contributor

sseshasa commented Jun 20, 2025

Rados Approved. See https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues71676.

@neha-ojha neha-ojha merged commit 39ba431 into ceph:main Jul 15, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ifed01 ifed01 ifed01 approved these changes

@batrick batrick batrick approved these changes

@aclamk aclamk Awaiting requested review from aclamk

Assignees

No one assigned

Labels

core needs-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MaxKellermann @ceph-jenkins @ifed01 @sseshasa @batrick @neha-ojha @SrinivasaBharath