rgw/rados: resolve CopyObject crash from remote zonegroup#61009
Merged
rgw/rados: resolve CopyObject crash from remote zonegroup#61009
Conversation
in a multi-zonegroup multisite configuration, CopyObject can name buckets in other zonegroups. we call fetch_remote_obj() to perform this copy, but it was crashing due to interaction with the beast frontend's coroutines Fixes: https://tracker.ceph.com/issues/69169 Signed-off-by: Casey Bodley <[email protected]> Reported-by: Seena Fallah <[email protected]>
Contributor
|
Shall we add in a test case for this as well? To catch any future regressions? |
Contributor
Author
@clwluvw shared a test case from the cross-zonegroup replication pr: https://github.com/clwluvw/ceph/blob/rgw-zonegroup-replication/src/test/rgw/rgw_multi/tests.py#L2306-L2347 apparently that needs to copy an object over ~4mb to trigger the crash. we'll need to split that test case out so we can backport it with this fix. that will also require backport of @smanjara's #60172 to reenable multi-zonegroup tests, along with that pr's depedencies |
dang
approved these changes
Jan 2, 2025
ivancich
added
needs-qa
wip-eric-testing-1
Member
|
jenkins test api |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in a multi-zonegroup multisite configuration, CopyObject can name buckets in other zonegroups. we call fetch_remote_obj() to perform this copy, but it was crashing due to interaction with the beast frontend's coroutines
Fixes: https://tracker.ceph.com/issues/69169
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e