dencoder tests fix type backwards incompatible checks #60945
Merged
SrinivasaBharath merged 2 commits intoceph:mainfrom Feb 3, 2025
Merged
dencoder tests fix type backwards incompatible checks #60945SrinivasaBharath merged 2 commits intoceph:mainfrom
SrinivasaBharath merged 2 commits intoceph:mainfrom
Conversation
NitzanMordhai
force-pushed
the
wip-nitzan-crushwrapper-corpus-squid
branch
from
4c31663 to
15a4758
Compare
ljflores
reviewed
Dec 9, 2024
Member
ljflores
left a comment
ljflores
left a comment
There was a problem hiding this comment.
There is a related make check failure:
workunits/dencoder/test_readable.py:17: error: Need type annotation for "fast_shouldnt_skip" (hint: "fast_shouldnt_skip: List[<type>] = ...") [var-annotated]
Found 1 error in 1 file (checked 287 source files)
mypy: exit 1 (18.56 seconds) /home/jenkins-buil
should_skip_object function needed to handle cascading backward compatibility checks. I also added improved handling of backward compatibility filtering in should_skip_object so we can better find backward comp. and skip them. Fixes: https://tracker.ceph.com/issues/69009 Signed-off-by: Nitzan Mordechai <[email protected]>
ceph-object-corpus submodule Signed-off-by: Nitzan Mordechai <[email protected]>
NitzanMordhai
force-pushed
the
wip-nitzan-crushwrapper-corpus-squid
branch
from
15a4758 to
882eaa7
Compare
Contributor
Author
ohh miss that one, fixed |
Contributor
Author
|
jenkins test api |
ljflores
reviewed
Dec 13, 2024
Member
ljflores
left a comment
ljflores
left a comment
There was a problem hiding this comment.
@NitzanMordhai the "ceph-object-corpus" submodule was updated- I don't think that was intentional?
Contributor
Author
yes, we have updated ceph-object-corpus branch, we need to update ceph with the submodule |
ljflores
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues in the dencoder tests related to backward compatibility checks.
It improves the handling of type skipping and testing logic by ensuring compatibility is properly checked across versions. Types introduced in newer versions are now correctly skipped for older decoder versions, following cascading backward compatibility rules.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e