rgw: respect policies in data sync in user mode#60685
Merged
Conversation
Source object policies aren't evaluated, causing access to be denied when the uid is bound to an account or IAM policies are involved. This can be fixed by passing the UID as 'rgwx-uid', allowing the source zone to handle policy evaluation. Fixes: https://tracker.ceph.com/issues/68884 Signed-off-by: Seena Fallah <[email protected]>
Destination object policies are skipped, resulting in access denial when IAM policies grant access to the UID. This can be resolved by using verify_bucket_permission() instead of verify_bucket_permission_no_policy(). Fixes: https://tracker.ceph.com/issues/68884 Signed-off-by: Seena Fallah <[email protected]>
This was referenced Nov 10, 2024
adamemerson
approved these changes
Nov 27, 2024
Member
Author
|
jenkins test api |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the data sync phase, both source and destination object permissions are evaluated locally on the destination zone, leading to two issues:
rgwx-uid, allowing the source zone to handle policy evaluation.verify_bucket_permission()instead ofverify_bucket_permission_no_policy().Fixes: https://tracker.ceph.com/issues/68884