rgw/multisite: revert "rgw/multisite: avoid redundant error repo entry logging#60589
Merged
rgw/multisite: revert "rgw/multisite: avoid redundant error repo entry logging#60589
Conversation
cbodley
reviewed
Nov 4, 2024
In order to keep the order of processing the generations, when the requested gen is higher than the current gen we log both into the error repo and process them in order again later. Fixes: https://tracker.ceph.com/issues/68805 Signed-off-by: Seena Fallah <[email protected]> This reverts commit a191f9a.
clwluvw
force-pushed
the
requested-gen-sync
branch
from
8915268 to
f07c4d4
Compare
smanjara
approved these changes
Nov 6, 2024
14 tasks
smanjara
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the requested gen than the bucket_status.incremental_gen to RGWSyncBucketShardCR as the old gen (bucket_status.incremental_gen) is stored in the error repo and will retried later.
Fixes: https://tracker.ceph.com/issues/68805