Skip to content

systemd: use CMake install prefix in templates#60575

Merged
SrinivasaBharath merged 1 commit intoceph:mainfrom
steven-chien:systemd-prefix
Mar 17, 2025
Merged

systemd: use CMake install prefix in templates#60575
SrinivasaBharath merged 1 commit intoceph:mainfrom
steven-chien:systemd-prefix

Conversation

@steven-chien
Copy link
Contributor

The current systemd services use hard-coded paths. This commit uses the CMake install prefix in the templates to set up paths to executables where they are actually installed.

@steven-chien steven-chien requested a review from a team as a code owner October 31, 2024 11:47
@github-actions github-actions bot added the rbd label Oct 31, 2024
tchaikov
tchaikov previously approved these changes Oct 31, 2024
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov
Copy link
Contributor

jenkins test api

@tchaikov tchaikov dismissed their stale review October 31, 2024 15:21

--cluster ceph has been deprecated.

@steven-chien
Copy link
Contributor Author

The flags have been dropped.

@idryomov
Copy link
Contributor

Please squash the second commit into the first -- no need to add the flags only to drop them in the following commit.

The current systemd services use hard coded paths.
This commit uses CMake install prefix in the templates to
setup paths to executables where they are actually installed.

Signed-off-by: steven <[email protected]>
@tchaikov
Copy link
Contributor

tchaikov commented Nov 1, 2024

jenkins test api

@idryomov
Copy link
Contributor

idryomov commented Nov 1, 2024

jenkins test api

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 31, 2024
@idryomov
Copy link
Contributor

idryomov commented Jan 2, 2025

@yuriw Please include this PR into a RADOS integration branch.

@idryomov idryomov removed the stale label Jan 2, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 3, 2025
@idryomov idryomov removed the stale label Mar 3, 2025
@idryomov
Copy link
Contributor

idryomov commented Mar 3, 2025

Please include this PR into a RADOS integration branch.

@yuriw It looks like this PR got missed.

@Naveenaidu
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants