rgw_cksum: permit fallback to checksum-type from create-multipart, in…#60282
rgw_cksum: permit fallback to checksum-type from create-multipart, in…#60282mattbenjamin wants to merge 2 commits intoceph:mainfrom
Conversation
|
(will provide s3-test) |
src/rgw/rgw_op.cc
Outdated
|
|
||
| if (cksum_filter) { | ||
| const auto& hdr = cksum_filter->header(); | ||
| auto expected_ck = cksum_filter->expected(*s->info.env); |
There was a problem hiding this comment.
For readability I think it would help to do away with the auto and instead spell out the actual type and comment as to what info it'll return.
| cksum_filter->verify(*s->info.env); // valid or no supplied cksum | ||
| cksum = get<1>(cksum_verify); | ||
| if (std::get<0>(cksum_verify)) { | ||
| if ((!expected_ck) || |
There was a problem hiding this comment.
We need a comment to explain the logic of this conditional.
ivancich
left a comment
ivancich
left a comment
There was a problem hiding this comment.
nit: I request a few comments to help explain the logic
… upload-part There appear to be workloads that provide a checksum algorithm in create-multipart-upload, but do not provide (what must be) the corresponding algorithm when uploading the parts. (complete-multipart-upload has no checksum argument, the value is implicit.) This behavior is inconsistent with at least some SDKs, but it is possibly accepted behavior in AWS S3, and is not logically necessary, since the originally supplied checksum type is already known. Therefore, change the behavior of upload-part to fall back to a checksum type that was sent with the corresponding create-multipart-upload request, if one is present, rather than failing with InvalidRequest. Fixes: https://tracker.ceph.com/issues/68513 Signed-off-by: Matt Benjamin <[email protected]>
mattbenjamin
force-pushed
the
wip-cksum-68513
branch
from
6b487a4 to
ca6cb7e
Compare
Improve readability based on feedback from Eric Ivancich review. Signed-off-by: Matt Benjamin <[email protected]>
mattbenjamin
force-pushed
the
wip-cksum-68513
branch
from
ca6cb7e to
85f41e9
Compare
|
this doesnt seem to be a pass; there are 4 instances of java s3-tests failing, and one failure of hadoop s3a; none appears to be a java checksum test. Will investigate further. |
Please re-run. I submitted some PRs in the last month or so that fixed a lot of this testing. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
is this still needed? |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
3 participants
… upload-part
There appear to be workloads that provide a checksum algorithm in create-multipart-upload, but do not provide (what must be) the corresponding algorithm when uploading the parts. (complete-multipart-upload has no checksum argument, the value is implicit.)
This behavior is inconsistent with at least some SDKs, but it is possibly accepted behavior in AWS S3, and is not logically necessary, since the originally supplied checksum type is already known.
Therefore, change the behavior of upload-part to fall back to a checksum type that was sent with the corresponding create-multipart-upload request, if one is present, rather than failing with InvalidRequest.
Fixes: https://tracker.ceph.com/issues/68513
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e