passed qa in https://pulpito.ceph.com/cbodley-2024-12-13_17:43:49-rgw-wip-65369-distro-default-smithi/

new test cases from ceph/s3-tests#594 passed:

2024-12-13T20:40:03.346 INFO:teuthology.orchestra.run.smithi083.stdout:s3tests_boto3/functional/test_s3.py::test_bucket_list_return_data_versioning_key_marker PASSED [ 38%]
2024-12-13T20:40:04.957 INFO:teuthology.orchestra.run.smithi083.stdout:s3tests_boto3/functional/test_s3.py::test_bucket_list_return_data_versioning_version_id_marker PASSED [ 38%]

@samakshd, thanks for noticing that! Have you looked into why this extra check is even necessary since the functions are all coded as exclusive?

rgw_bucket_list has local variables named start_after_omap_key and start_after_entry_key, which are named to show that they're intended to be exclusive.

That in turn calls get_obj_vals.

And ultimately this is called, and the parameter is named start_after, implying it's exclusive:

extern int cls_cxx_map_get_vals(cls_method_context_t hctx,  
                                const std::string& start_after,  
                                const std::string& filter_prefix, 
                                uint64_t max_to_get, 
                                std::map<std::string, ceph::buffer::list> *vals,
                                bool *more);  

If there's a logic error in that chain, I would prefer a solution that fixed it rather than checking each entry returned.

So I'm wondering if you traced that through and what ideas you might have towards that. Thanks!

Also, I want to apologize for the very late review, @samakshd!

jenkins test make check

Can one of the admins verify this patch?

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!