Skip to content

Comments

tools/rados: generalize the OMAP benchmarking to cover listing as well#60277

Merged
rzarzynski merged 5 commits intoceph:mainfrom
rzarzynski:wip-tools-rados-omap-listbench
Mar 25, 2025
Merged

tools/rados: generalize the OMAP benchmarking to cover listing as well#60277
rzarzynski merged 5 commits intoceph:mainfrom
rzarzynski:wip-tools-rados-omap-listbench

Conversation

@rzarzynski
Copy link
Contributor

@rzarzynski rzarzynski commented Oct 12, 2024

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rzarzynski rzarzynski requested a review from a team as a code owner October 12, 2024 10:30
@github-actions github-actions bot added the core label Oct 12, 2024
rzarzynski
rzarzynski commented Oct 12, 2024
View reviewed changes
src/tools/rados/rados.cc
return io_ctx.aio_read(oid, completions[slot], pbl, len, offset);
int ret = 0;
if (destination & OP_DEST_OBJ) {
ret = io_ctx.aio_read(oid, completions[slot], pbl, len, offset);
Copy link
Contributor Author

@rzarzynski rzarzynski Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no objections, I would like to unify the data read with OMAP / attrs through the ObjectReadOperation.

@rzarzynski rzarzynski mentioned this pull request Oct 15, 2024
Closed
14 tasks
@markhpc
Copy link
Member

markhpc commented Oct 17, 2024

@rzarzynski no objection here, but I tend not to use rados bench so much these days.

ifed01
ifed01 reviewed Oct 21, 2024
View reviewed changes
ronen-fr
ronen-fr reviewed Oct 22, 2024
View reviewed changes
ronen-fr
ronen-fr reviewed Oct 22, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 21, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 21, 2024
@rzarzynski rzarzynski removed the stale label Jan 13, 2025
@rzarzynski rzarzynski force-pushed the wip-tools-rados-omap-listbench branch from 020e0e9 to d56150d Compare February 13, 2025 14:05
@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 13, 2025

@ronen-fr, @ifed01: would you mind a second round?

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 14, 2025

jenkins test make check

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 20, 2025

jenkins retest this please

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 21, 2025 

/home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/rados/rados.cc:1128:11: error: 'omap_get_vals' is deprecated [-Werror,-Wdeprecated-declarations]

@rzarzynski rzarzynski force-pushed the wip-tools-rados-omap-listbench branch from d56150d to e963bdb Compare February 26, 2025 23:10
@rzarzynski
tools/rados: generalize the OMAP benchmarking to cover listing
9c60cfc 
Signed-off-by: Radoslaw Zarzynski <[email protected]>
@rzarzynski
tools/rados: deprecate --write-{object,omap,xattr}
87d633d 
With the introduction of OMAP read benchmarking they became
`--object`, `--omap` and `--xattr` respectively.

Signed-off-by: Radoslaw Zarzynski <[email protected]>
@rzarzynski
tools/rados: refactor NULL -> nullptr in main()
e8e8d97 
Signed-off-by: Radoslaw Zarzynski <[email protected]>
@rzarzynski rzarzynski force-pushed the wip-tools-rados-omap-listbench branch from e963bdb to e8e8d97 Compare February 27, 2025 00:12
@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 27, 2025

Dashboard's failure. Seems unrelated.

<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0xb82c28 node::OOMErrorHandler(char const*, v8::OOMDetails const&) [node]
 2: 0xeed540 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [node]
 3: 0xeed827 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [node]

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 27, 2025

jenkins test make check

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 27, 2025 

The following tests FAILED:
	203 - unittest_deferred (Subprocess aborted)
	246 - unittest_posix_bucket_cache (Failed)

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Feb 27, 2025

jenkins test make check

1 similar comment
@rzarzynski
Copy link
Contributor Author

rzarzynski commented Mar 3, 2025

jenkins test make check

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Mar 3, 2025

jenkins test make check arm64

@ljflores
Copy link
Member

ljflores commented Mar 14, 2025

Hey all, apologies for the delay in testing- the QA tracker was mislabeled. Reviews are ongoing now here: https://tracker.ceph.com/issues/70205

@ljflores
Copy link
Member

ljflores commented Mar 25, 2025

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues70205

@rzarzynski rzarzynski merged commit da60c90 into ceph:main Mar 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ifed01 ifed01 ifed01 approved these changes

@ronen-fr ronen-fr Awaiting requested review from ronen-fr

Assignees

No one assigned

Labels

core needs-qa performance wip-yuri3-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rzarzynski @markhpc @ljflores @ifed01 @ronen-fr @yuriw