rgw: initialize createparams zone_placement to avoid garbage value#60254
Merged
rgw: initialize createparams zone_placement to avoid garbage value#60254
Conversation
When creating a bucket from a secondary zonegroup and forwarding the request to the master zonegroup (i.e., when `bucket_zonegroup != &my_zonegroup`), the `createparams.zone_placement` may remain uninitialized. This can lead to garbage values and result in a segmentation fault due to invalid memory access. By explicitly initializing `zone_placement` to `nullptr`, we can eliminate this issue in cases where zone_placement is referenced like `init_default_bucket_layout`. Fixes: https://tracker.ceph.com/issues/68500 Signed-off-by: Seena Fallah <[email protected]>
This was referenced Oct 10, 2024
cbodley
approved these changes
Oct 11, 2024
Contributor
|
Contributor
|
jenkins test make check |
2 similar comments
Member
Author
|
jenkins test make check |
Member
Author
|
jenkins test make check |
Contributor
|
Contributor
|
jenkins test make check |
14 tasks
When creating a bucket in the secondary zonegroup, the `rgwx-zonegroup` is mistakenly set to the master zonegroup when forwarding the request. Instead, it should be set to the secondary zonegroup so that the master zonegroup creates the bucket for the intended zonegroup rather than for itself. Fixes: https://tracker.ceph.com/issues/67610 Signed-off-by: Seena Fallah <[email protected]>
Contributor
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
Member
Author
|
jenkins test api |
Member
Author
|
jenkins test make check arm64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a bucket from a secondary zonegroup and forwarding the request to the master zonegroup
(i.e., when
bucket_zonegroup != &my_zonegroup), thecreateparams.zone_placementmay remain uninitialized. This can lead to garbage values and result in a segmentation fault due to invalid memory access.By explicitly initializing
zone_placementtonullptr, we can eliminate this issue in cases where zone_placement is referenced likeinit_default_bucket_layout.Fixes: https://tracker.ceph.com/issues/68500