Skip to content

Comments

doc: Document the Windows CI job#60030

Merged
zdover23 merged 1 commit intoceph:mainfrom
petrutlucian94:document_windows_ci
Sep 27, 2024
Merged

doc: Document the Windows CI job#60030
zdover23 merged 1 commit intoceph:mainfrom
petrutlucian94:document_windows_ci

Conversation

@petrutlucian94
Copy link
Contributor

@petrutlucian94 petrutlucian94 commented Sep 27, 2024

We're adding a document that describes:

  • the steps performed by the Windows CI job
  • artifact structure
  • frequently asked questions

The document is meant to assist the Ceph developers in investigating CI failures. This is especially important as the Windows CI job runs integration tests that would otherwise only be executed by Teuthology, thus helping catch potential regressions quickly.

Note that the identified regressions are not necessarily Windows specific, usually affecting Linux builds as well.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@zdover23 zdover23 self-requested a review September 27, 2024 14:30
Copy link
Contributor

@zdover23 zdover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution.

I'll merge this as soon as the tests are passed and I'll backport it.

There are minor grammar and comma-splice complaints, but nothing that I can't address in a future PR.

Thanks for this.

@zdover23 zdover23 changed the title Document the Windows CI job doc: Document the Windows CI job Sep 27, 2024
@petrutlucian94
Copy link
Contributor Author

@zdover23 thank you so much for reviewing this on such a short notice. I've addressed the issues and added a link on the Windows install page for better visibility.

@zdover23
Copy link
Contributor

@zdover23 thank you so much for reviewing this on such a short notice. I've addressed the issues and added a link on the Windows install page for better visibility.

I'm glad to help. I just happened to be at the terminal, working on a separate matter and waiting for a build to complete. We got lucky.

@petrutlucian94
Copy link
Contributor Author

petrutlucian94 commented Sep 27, 2024

Oh, forgot to add an important note:

Timeouts and missing test results are often an indication that a process crashed. Note that the ceph status
is printed out on the console before and after performing the tests, which can help identify crashed services.

You may also want to check the service logs (both client and server side). Also, be aware that the Windows
"application" event log will contain entries in case of crashed Windows processes.

LE: done.

@petrutlucian94 petrutlucian94 force-pushed the document_windows_ci branch 2 times, most recently from 499e052 to 27e5339 Compare September 27, 2024 17:36
We're adding a document that describes:

* the steps performed by the Windows CI job
* artifact structure
* frequently asked questions

The document is meant to assist the Ceph developers in investigating
CI failures. This is especially important as the Windows CI job runs
integration tests that would otherwise only be executed by
Teuthology, thus helping catch potential regressions quickly.

Note that the identified regressions are not necessarily Windows
specific, usually affecting Linux builds as well.

Signed-off-by: Lucian Petrut <[email protected]>
@zdover23 zdover23 merged commit 2e2abbf into ceph:main Sep 27, 2024
@zdover23
Copy link
Contributor

#60033 - Squid backport
#60034 - Reef backport
#60035 - Quincy backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants