Conversation
zdover23
left a comment
There was a problem hiding this comment.
This is a great contribution.
I'll merge this as soon as the tests are passed and I'll backport it.
There are minor grammar and comma-splice complaints, but nothing that I can't address in a future PR.
Thanks for this.
02008ba to
b2aad7a
Compare
|
@zdover23 thank you so much for reviewing this on such a short notice. I've addressed the issues and added a link on the Windows install page for better visibility. |
b2aad7a to
384ec87
Compare
I'm glad to help. I just happened to be at the terminal, working on a separate matter and waiting for a build to complete. We got lucky. |
384ec87 to
b12ce60
Compare
|
Oh, forgot to add an important note: LE: done. |
499e052 to
27e5339
Compare
We're adding a document that describes: * the steps performed by the Windows CI job * artifact structure * frequently asked questions The document is meant to assist the Ceph developers in investigating CI failures. This is especially important as the Windows CI job runs integration tests that would otherwise only be executed by Teuthology, thus helping catch potential regressions quickly. Note that the identified regressions are not necessarily Windows specific, usually affecting Linux builds as well. Signed-off-by: Lucian Petrut <[email protected]>
27e5339 to
bb7d5b6
Compare
We're adding a document that describes:
The document is meant to assist the Ceph developers in investigating CI failures. This is especially important as the Windows CI job runs integration tests that would otherwise only be executed by Teuthology, thus helping catch potential regressions quickly.
Note that the identified regressions are not necessarily Windows specific, usually affecting Linux builds as well.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e