tools/ceph-bluestore-tool: optimize offline trim report info#59633
tools/ceph-bluestore-tool: optimize offline trim report info#59633
Conversation
src/os/bluestore/BlueFS.cc
Outdated
| return; | ||
| } | ||
| if (is_shared_alloc(bdev_id)) { | ||
| outss << "device " << type << " shared alloc bluestore, please trim block"; |
There was a problem hiding this comment.
Wouldn't it be better to rephrase to:
device $type shares allocations with main device, trimming skipped.
YiteGu
force-pushed
the
optimize-offline-trim-report-info
branch
from
0c8806e to
548d069
Compare
|
@YiteGu can you please check: https://pulpito.ceph.com/yuriw-2024-10-04_14:45:24-rados-wip-yuri4-testing-2024-10-02-1513-distro-default-smithi/7932764 to make sure it's not related to that PR |
I want to see more detail, but this log link display blank: Log: http://qa-proxy.ceph.com/teuthology/yuriw-2024-10-04_14:45:24-rados-wip-yuri4-testing-2024-10-02-1513-distro-default-smithi/7932764/teuthology.log |
@NitzanMordhai I think it's not related to this PR :). Cc: @ifed01 |
Right. That's an unrelated issue covered by https://tracker.ceph.com/issues/68528 |
|
@NitzanMordhai - how do we proceed with this PR? |
@yuriw please add that PR to the next batch! |
|
jenkins test make check arm64 |
6 participants
Fixes: https://tracker.ceph.com/issues/67932
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e