rgw/multisite: avoid redundant error repo entry logging#59580
Merged
rgw/multisite: avoid redundant error repo entry logging#59580
Conversation
adamemerson
approved these changes
Sep 4, 2024
Contributor
adamemerson
left a comment
adamemerson
left a comment
There was a problem hiding this comment.
LGTM, but could you please change the commit message to something like:
rgw/multisite: avoid redundant error repo entry logging
in bucket incremental sync, if a generation other than the current generation is requested,
we mark it with -EAGAIN and retry in error repo in RGWDataSyncSingleEntry(). within this block, we check
if that requested generation is lesser than the current gen, write it to error repo, set -EAGAIN and write
it to error repo in the outer function once again. don't duplicate error repo entry addition for this condition.
Signed-off-by: Shilpa Jagannath <[email protected]>
A lot of git tools assume commit messages will have a 50–60 character subject line (so there's room for hashes and stuff) and 72-character (so there's room for > marks for email quoting) body after a blank.
Contributor
Contributor
@smanjara could you please address Adam's review comment? |
in bucket incremental sync, if a generation other than the current generation is requested, we mark it with -EAGAIN and retry in error repo in RGWDataSyncSingleEntry(). within this block, we check if that requested generation is lesser than the current gen, write it to error repo, set -EAGAIN and write it to error repo in the outer function once again. don't duplicate error repo entry addition for this condition. Signed-off-by: Shilpa Jagannath <[email protected]>
smanjara
force-pushed
the
rgw-data-sync-redundant-retries
branch
from
0c9baf3 to
a191f9a
Compare
Contributor
Author
sorry, done. |
Contributor
|
jenkins test make check |
Contributor
|
jenkins test windows |
Contributor
Author
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e