Skip to content

Comments

mds: move fscrypt inode_t metadata to mds_co mempool#59414

Merged
batrick merged 4 commits intoceph:mainfrom
batrick:i67687
Sep 5, 2024
Merged

mds: move fscrypt inode_t metadata to mds_co mempool#59414
batrick merged 4 commits intoceph:mainfrom
batrick:i67687

Conversation

@batrick
Copy link
Member

@batrick batrick commented Aug 22, 2024 •
edited
Loading

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

batrick added 4 commits August 22, 2024 14:35
@batrick
include/buffer: add helpers for uint8_t vectors
814245c 
Signed-off-by: Patrick Donnelly <[email protected]>
@batrick
mds: move fscrypt_auth inode_t metadata to mds_co mempool
ed9481c 
https://tracker.ceph.com/issues/67687
Signed-off-by: Patrick Donnelly <[email protected]>
@batrick
mds: move fscrypt_file inode_t metadata to mds_co mempool
bf8f704 
Fixes: https://tracker.ceph.com/issues/67687
Signed-off-by: Patrick Donnelly <[email protected]>
@batrick
mds: move fscrypt_last_block to vector in mds_co mempool
190868a 
Encoding doesn't change.

Fixes: https://tracker.ceph.com/issues/67687
Signed-off-by: Patrick Donnelly <[email protected]>
@batrick batrick requested review from a team and lxbsz August 22, 2024 18:40
@github-actions github-actions bot added the cephfs Ceph File System label Aug 22, 2024
@batrick
Copy link
Member Author

batrick commented Aug 23, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Aug 23, 2024

jenkins test make check arm64

1 similar comment
@batrick
Copy link
Member Author

batrick commented Aug 23, 2024

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Aug 27, 2024

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Aug 27, 2024

This PR is under test in https://tracker.ceph.com/issues/67757.

@batrick
Copy link
Member Author

batrick commented Aug 29, 2024

https://tracker.ceph.com/issues/67757#note-4

@vshankar
Copy link
Contributor

vshankar commented Aug 30, 2024

@batrick I'm half way through this change. Will finish up review soon.

rishabh-d-dave
rishabh-d-dave approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent some time with this, looks okay to me. But I must add I am not well acquainted code region, so see my approval accordingly.

EDIT: would be nice if we could add rationale behind this change in commit message and/or in ticket and PR description.

chrisphoffman
chrisphoffman reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@chrisphoffman chrisphoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the verification you did for showing that fscrypt memory usage can now be tracked via mempool? I did some analysis here on my findings.

@batrick
Copy link
Member Author

batrick commented Aug 30, 2024

Can you share the verification you did for showing that fscrypt memory usage can now be tracked via mempool? I did some analysis here on my findings.

I didn't bother verifying it. Your analysis (thanks) looks like this PR worked as should be expected.

chrisphoffman
chrisphoffman approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@chrisphoffman chrisphoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batrick batrick merged commit 7732b01 into ceph:main Sep 5, 2024
@batrick batrick deleted the i67687 branch September 5, 2024 12:37
@batrick batrick mentioned this pull request Sep 5, 2024
Merged
@batrick batrick mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@chrisphoffman chrisphoffman chrisphoffman approved these changes

@lxbsz lxbsz Awaiting requested review from lxbsz

Assignees

No one assigned

Labels

cephfs Ceph File System needs-review wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@batrick @vshankar @rishabh-d-dave @chrisphoffman