rgw: send self zonegroup on forward to master#59305
rgw: send self zonegroup on forward to master#59305
Conversation
1704110 to
ff2e7ae
Compare
|
@smanjara Could you take a look at this and see if it seems reasonable? Thank you. |
ff2e7ae to
6fec6a4
Compare
6fec6a4 to
cd43689
Compare
|
the first commit dealing with rgwx-zonegroup looks correct to me. |
|
Regarding (6873f06), right if we have #59960 merged then that wouldn't be a problem... and I guess logically with the function name ("forward") we can eliminate the coverage of this behavior. I'll drop it. |
cd43689 to
bf63512
Compare
When creating a bucket in the secondary zonegroup, the `rgwx-zonegroup` is mistakenly set to the master zonegroup when forwarding the request. Instead, it should be set to the secondary zonegroup so that the master zonegroup creates the bucket for the intended zonegroup rather than for itself. Fixes: https://tracker.ceph.com/issues/67610 Signed-off-by: Seena Fallah <[email protected]>
bf63512 to
9769fb2
Compare
|
I guess the third commit was a consequence of my second commit :) |
|
Thanks for the review @smanjara - Do we need qa on this? if so can you please add the |
|
this commit was added into #60254. closing the pr. |
When creating a bucket in the secondary zonegroup, the
rgwx-zonegroupis mistakenly set to the master zonegroup when forwarding the request. Instead, it should be set to the secondary zonegroup so that the master zonegroup creates the bucket for the intended zonegroup rather than for itself.Fixes: https://tracker.ceph.com/issues/67610