Conversation
|
jenkins test make check |
|
jenkins test make check arm64 |
|
This PR is under test in https://tracker.ceph.com/issues/67563. |
src/librbd/CMakeLists.txt
Outdated
| set_target_properties(librbd PROPERTIES | ||
| OUTPUT_NAME rbd | ||
| VERSION 1.19.0 | ||
| VERSION 1.19.3 |
There was a problem hiding this comment.
@idryomov ^ is this okay? We've never done a release bump like this before TMK.
There was a problem hiding this comment.
I don't have the context for "pre-kickoff".
For tentacle I'd expect it to be 1.20.0. For a temporary workaround in main for something, this version could probably be left as is (i.e. 1.19.0).
There was a problem hiding this comment.
This "pre-kickoff" is just minimal changes necessary to get upgrades working from squid to main. (There are barriers in teuthology and possibly other places which prevent upgrades that appear to go backwards.)
There was a problem hiding this comment.
@idryomov also as a meta comment: would it not be better for this version to be pulled from the top-level CMakeLists.txt?
There was a problem hiding this comment.
Probably not. It might make more sense to pull it from src/include/rbd/librbd.h -- it corresponds to LIBRBD_VER_MAJOR, LIBRBD_VER_MINOR and LIBRBD_VER_EXTRA there.
Note that we only change the minor there (the second component) and that nothing changes in stable branches (i.e. 1.19.0 would be the version both the initial squid release and all squid backport releases).
batrick
force-pushed
the
tentacle-prekickoff
branch
from
bbfbc17 to
f22fdf1
Compare
To get upgrade tests working before kickoff, band-aid the version to vX.3.0. Fixes: https://tracker.ceph.com/issues/67335 Signed-off-by: Patrick Donnelly <[email protected]>
batrick
force-pushed
the
tentacle-prekickoff
branch
from
f22fdf1 to
1b0e5d8
Compare
|
This PR is under test in https://tracker.ceph.com/issues/67722. |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
This PR is under test in https://tracker.ceph.com/issues/67757. |
|
I don't think this will need to be merged since the git tag v19.3.0 is all that's needed. |
2 participants
DNM, testing if this is a valid band-aid in an
fsrun.To get upgrade tests working before kickoff, band-aid the version to vX.3.0. I think this could be a valid pre-kickoff task after branching a new release so that upgrade runs work as expected. Right now we are doing tests from
v19.1.X(squid RC) tov19.0.0(main) which fails with errors like:https://pulpito.ceph.com/pdonnell-2024-08-14_02:13:41-fs-wip-pdonnell-testing-20240813.125846-debug-distro-default-smithi/7854205/
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e