squid: rgw: revert account-related changes to get_iam_policy_from_attr()#59221
Merged
cbodley merged 2 commits intoceph:squidfrom Aug 29, 2024
Merged
squid: rgw: revert account-related changes to get_iam_policy_from_attr()#59221cbodley merged 2 commits intoceph:squidfrom
cbodley merged 2 commits intoceph:squidfrom
Conversation
while bucket ARNs in iam policies don't include account names, policy evaluation does need to differentiate between buckets in different tenant namespaces when requests pass bucket/object ARNs into verify_bucket/object_permission(), those do include the bucket's tenant name. to match against those ARNs, we also need to pass the requested bucket's tenant name into get_iam_policy_from_attr() Fixes: https://tracker.ceph.com/issues/67464 Signed-off-by: Casey Bodley <[email protected]> (cherry picked from commit d7377da)
Signed-off-by: Casey Bodley <[email protected]> (cherry picked from commit f38429b)
dang
approved these changes
Aug 22, 2024
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/67554
backport of #59169
parent tracker: https://tracker.ceph.com/issues/67464
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh