client: use vectors for context lists#59171
Merged
Conversation
To avoid an allocation for each Context and improved cache locality. Signed-off-by: Patrick Donnelly <[email protected]>
Member
Author
|
jenkins test make check arm64 |
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/67516. |
dparmar18
reviewed
Aug 13, 2024
| } | ||
|
|
||
| void Client::wait_on_context_list(list<Context*>& ls) | ||
| void Client::wait_on_context_list(std::vector<Context*>& ls) |
Contributor
There was a problem hiding this comment.
We have already brought std::vector into the current scope at line 159 using std::vector;
Member
Author
There was a problem hiding this comment.
I prefer explicit namespacing (and we generally do so everywhere).
Contributor
There was a problem hiding this comment.
so should we remove the import at line 159? it doesn't make sense to keep it if we want to keep it explicit.
dparmar18
reviewed
Aug 13, 2024
Member
Author
|
jenkins test make check arm64 |
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/67563. |
vshankar
approved these changes
Aug 27, 2024
pritha-srivastava
pushed a commit
to pritha-srivastava/ceph
that referenced
this pull request
Aug 28, 2024
* refs/pull/59171/head: client: use vectors for context lists Reviewed-by: Venky Shankar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid an allocation for each Context and improved cache locality.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e