Skip to content

mon/thrasher: set stopping#59166

Merged
vshankar merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-mon-thrasher-stop-set
Aug 22, 2024
Merged

mon/thrasher: set stopping#59166
vshankar merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-mon-thrasher-stop-set

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Aug 12, 2024

stopping was set by PR #58282 to bool instead of set()

Fixes: https://tracker.ceph.com/issues/67496

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@batrick
Copy link
Member

batrick commented Aug 12, 2024

jenkins test api

@batrick
Copy link
Member

batrick commented Aug 12, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented Aug 12, 2024

jenkins test api

@batrick
Copy link
Member

batrick commented Aug 13, 2024

@batrick
Copy link
Member

batrick commented Aug 15, 2024

vshankar added a commit to vshankar/ceph that referenced this pull request Aug 20, 2024
* refs/pull/59166/head:
	mon/thrasher: set stopping

Reviewed-by: Radoslaw Zarzynski <[email protected]>
Reviewed-by: Patrick Donnelly <[email protected]>
Reviewed-by: Laura Flores <[email protected]>
Reviewed-by: Venky Shankar <[email protected]>
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 76226b3 into ceph:main Aug 22, 2024
@batrick
Copy link
Member

batrick commented Aug 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants