client: Prevent race condition when printing Inode in ll_sync_inode#59162
Merged
client: Prevent race condition when printing Inode in ll_sync_inode#59162
Conversation
lxbsz
reviewed
Aug 12, 2024
In the ll_sync_inode function, the entire Inode structure is printed without holding a lock. This can lead to a race condition when evaluating the assertion in xlist<ObjectCacher::Object*>::size(), resulting in abnormal behavior. Fixes: https://tracker.ceph.com/issues/67491 Co-authored-by: dongdong tao <[email protected]> Signed-off-by: Chengen Du <[email protected]>
yukariatlas
force-pushed
the
ll-sync-inode-67491
branch
from
6c3c205 to
2b78a5b
Compare
batrick
approved these changes
Aug 12, 2024
lxbsz
approved these changes
Aug 13, 2024
Member
|
jenkins test api |
Member
|
jenkins test make check |
Member
|
(wrong button) |
Member
|
This PR is under test in https://tracker.ceph.com/issues/67516. |
Member
|
jenkins test api |
Member
|
jenkins test make check arm64 |
Member
|
This PR is under test in https://tracker.ceph.com/issues/67563. |
pritha-srivastava
pushed a commit
to pritha-srivastava/ceph
that referenced
this pull request
Aug 28, 2024
* refs/pull/59162/head: client: Prevent race condition when printing Inode in ll_sync_inode Reviewed-by: Xiubo Li <[email protected]> Reviewed-by: Patrick Donnelly <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the ll_sync_inode function, the entire Inode structure is printed without holding a lock. This can lead to a race condition when evaluating the assertion in xlistObjectCacher::Object*::size(), resulting in abnormal behavior.
Fixes: https://tracker.ceph.com/issues/67491