rgw: fix CompleteMultipart error handling regression#57257
Merged
rgw: fix CompleteMultipart error handling regression#57257
Conversation
14 tasks
Contributor
Author
|
the |
Contributor
|
could be helpful to have brief comment in the commit messages explaining it's intended effect |
most requests operate directly on s->object. there's no reason to allocate a separate target_obj for the same purpose Signed-off-by: Casey Bodley <[email protected]>
get_notification() should be associated with the target object s->object. the meta_obj has the wrong object name, so required passing s->object->get_name() as an extra argument importantly, Notification no longer depends on the lifetime of meta_obj to avoid a dangling pointer, while the lifetime of s->object is guaranteed Signed-off-by: Casey Bodley <[email protected]>
move publish_complete() and meta_obj->delete_object() back to execute() so they only run on success. this allows several member variables to move back to execute()'s stack as well Fixes: https://tracker.ceph.com/issues/65746 Signed-off-by: Casey Bodley <[email protected]>
Contributor
Author
This was referenced May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#54569 moved some CompleteMultipart code around, and introduced a regression in the error path that causes the 'multipart meta object' to be deleted prematurely
Fixes: https://tracker.ceph.com/issues/65746
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e