Skip to content

rgw: implement x-amz-replication-status for PENDING & COMPLETED#57060

Merged
cbodley merged 4 commits intoceph:mainfrom
awojno-bloomberg:wip-awojno-status-header
Jul 3, 2024
Merged

rgw: implement x-amz-replication-status for PENDING & COMPLETED#57060
cbodley merged 4 commits intoceph:mainfrom
awojno-bloomberg:wip-awojno-status-header

Conversation

@awojno-bloomberg
Copy link
Contributor

@awojno-bloomberg awojno-bloomberg commented Apr 23, 2024 •
edited
Loading

Tracker: https://tracker.ceph.com/issues/64436

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@awojno-bloomberg awojno-bloomberg requested a review from a team as a code owner April 23, 2024 18:03
@awojno-bloomberg awojno-bloomberg mentioned this pull request Apr 23, 2024
Closed
14 tasks
cbodley
cbodley reviewed Apr 26, 2024
View reviewed changes
@awojno-bloomberg awojno-bloomberg force-pushed the wip-awojno-status-header branch 4 times, most recently from f228625 to 22dad4a Compare May 3, 2024 17:07
@awojno-bloomberg awojno-bloomberg force-pushed the wip-awojno-status-header branch from 22dad4a to c5369a0 Compare May 10, 2024 16:10
@awojno-bloomberg awojno-bloomberg force-pushed the wip-awojno-status-header branch from c5369a0 to 3161e24 Compare May 13, 2024 18:59
@github-actions
Copy link

github-actions bot commented May 31, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@smanjara smanjara mentioned this pull request Jun 5, 2024
Merged
14 tasks
@awojno-bloomberg awojno-bloomberg force-pushed the wip-awojno-status-header branch from bce7fd3 to 402db37 Compare June 10, 2024 17:38
smanjara
smanjara reviewed Jun 11, 2024
View reviewed changes
cbodley
cbodley reviewed Jun 12, 2024
View reviewed changes
smanjara
smanjara reviewed Jun 12, 2024
View reviewed changes
smanjara
smanjara reviewed Jun 12, 2024
View reviewed changes
@awojno-bloomberg awojno-bloomberg force-pushed the wip-awojno-status-header branch from 402db37 to d10477e Compare June 13, 2024 17:17
cbodley
cbodley reviewed Jun 21, 2024
View reviewed changes
@cbodley
Copy link
Contributor

cbodley commented Jun 21, 2024

failed qa in https://pulpito.ceph.com/cbodley-2024-06-20_13:04:58-rgw-wip-cbodley-testing-distro-default-smithi/

@awojno-bloomberg awojno-bloomberg force-pushed the wip-awojno-status-header branch from d10477e to 3c1041a Compare June 21, 2024 19:51
cbodley
cbodley reviewed Jun 26, 2024
View reviewed changes
cbodley and others added 2 commits June 28, 2024 13:03
@cbodley @awojno-bloomberg
rgw: PubObj uses RGWObjTags by value
3faf163 
stop wrapping RGWObjTags in a unique_ptr, and just use empty() or count() to determine whether any tags are present

Signed-off-by: Casey Bodley <[email protected]>
@awojno-bloomberg
rgw: correct tag checking logic in bucket_exports_object
4401be8 
Signed-off-by: Alex Wojno <[email protected]>
cbodley
cbodley approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good

@cbodley cbodley mentioned this pull request Jun 28, 2024
Closed
@cbodley
Copy link
Contributor

cbodley commented Jul 3, 2024

passed qa in https://pulpito.ceph.com/cbodley-2024-07-03_01:53:26-rgw-wip-cbodley-testing-distro-default-smithi/

2024-07-03T02:41:10.315 INFO:tasks.rgw_multisite_tests:rgw_multi.tests.test_replication_status ... ok

@cbodley cbodley merged commit cdc2779 into ceph:main Jul 3, 2024
@jmundack
Copy link
Contributor

jmundack commented Jul 3, 2024

thanks @cbodley !

cbodley
cbodley reviewed Jul 11, 2024
View reviewed changes
This was referenced Jul 11, 2024
Merged
Closed
@smanjara smanjara mentioned this pull request Jul 15, 2024
Closed
14 tasks
@cbodley cbodley mentioned this pull request Jul 18, 2024
Merged
NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024
@cbodley @NitzanMordhai
Merge pull request ceph#57060 from awojno-bloomberg/wip-awojno-status…
126cf39 
…-header

rgw: implement x-amz-replication-status for PENDING & COMPLETED

Reviewed-by: Shilpa Jagannath <[email protected]>
Reviewed-by: Casey Bodley <[email protected]>
@awojno-bloomberg awojno-bloomberg mentioned this pull request Nov 20, 2024
Merged
@cbodley cbodley mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

@smanjara smanjara smanjara approved these changes

Assignees

No one assigned

Labels

needs-qa rgw tests wip-cbodley-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@awojno-bloomberg @cbodley @jmundack @smanjara