Skip to content

Comments

qa: ignore container checkpoint/restore related selinux denials for centos9#55908

Merged
vshankar merged 2 commits intoceph:mainfrom
vshankar:wip-64616
Mar 7, 2024
Merged

qa: ignore container checkpoint/restore related selinux denials for centos9#55908
vshankar merged 2 commits intoceph:mainfrom
vshankar:wip-64616

Conversation

@vshankar
Copy link
Contributor

@vshankar vshankar commented Mar 4, 2024

Fixes: http://tracker.ceph.com/issues/64616

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@vshankar
Copy link
Contributor Author

vshankar commented Mar 6, 2024

@vshankar
Copy link
Contributor Author

vshankar commented Mar 6, 2024

jenkins retest this please

Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In message of commit ce62148, s/bought/brought.

@rishabh-d-dave
Copy link
Contributor

In message of commit ce62148, s/bought/brought.

Also changing commit message title to use allowlist instead of whitelist for selinux denials would be nicer.

Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@vshankar
Copy link
Contributor Author

vshankar commented Mar 6, 2024

In message of commit ce62148, s/bought/brought.

Also changing commit message title to use allowlist instead of whitelist for selinux denials would be nicer.

Done.

@vshankar vshankar requested a review from a team March 6, 2024 09:29
@vshankar
Copy link
Contributor Author

vshankar commented Mar 6, 2024

jenkins test make check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants