Skip to content

Comments

mgr/snap_schedule: handle volume delete#55145

Merged
vshankar merged 4 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-handle-volume-delete
Dec 26, 2024
Merged

mgr/snap_schedule: handle volume delete#55145
vshankar merged 4 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-handle-volume-delete

Conversation

@mchangir
Copy link
Contributor

@mchangir mchangir commented Jan 11, 2024 •
edited
Loading

Remove references to timers and db connection that refer to paths in the deleted volume.

This is a best case effort and not 100% safe. There can be race conditions where the db connection is closed while the module is executing a query on the db while the volume itself is deleted.

Hopefully there won't be many tracebacks seen.

Fixes: https://tracker.ceph.com/issues/63999
Signed-off-by: Milind Changire [email protected]

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@mchangir mchangir marked this pull request as draft January 11, 2024 12:56
@mchangir mchangir requested a review from vshankar January 11, 2024 12:56
@mchangir mchangir force-pushed the mgr-snap_schedule-handle-volume-delete branch from bfe8f64 to 60532ab Compare January 12, 2024 06:37
@vshankar vshankar requested a review from a team January 16, 2024 14:04
@vshankar
Copy link
Contributor

vshankar commented Jan 16, 2024

@mchangir Please add documentation to recover from the module failing since the race cannot be fixed in totality.

@vshankar vshankar marked this pull request as ready for review January 16, 2024 14:07
@mchangir mchangir force-pushed the mgr-snap_schedule-handle-volume-delete branch from 60532ab to c4ff962 Compare January 17, 2024 06:03
@mchangir mchangir requested a review from a team as a code owner January 17, 2024 06:03
@github-actions github-actions bot added cephfs Ceph File System documentation labels Jan 17, 2024
@mchangir
Copy link
Contributor Author

mchangir commented Jan 17, 2024 •
edited
Loading

@mchangir Please add documentation to recover from the module failing since the race cannot be fixed in totality.

added note to docs

@mchangir
Copy link
Contributor Author

mchangir commented Mar 12, 2024

jenkins test make check

vshankar
vshankar reviewed Mar 12, 2024
View reviewed changes
@mchangir mchangir force-pushed the mgr-snap_schedule-handle-volume-delete branch from c4ff962 to 9e9025a Compare March 12, 2024 13:48
@vshankar
Copy link
Contributor

vshankar commented Mar 25, 2024

I'll plan to test this change out this week.

@github-actions
Copy link

github-actions bot commented May 24, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 24, 2024
@github-actions
Copy link

github-actions bot commented Jun 23, 2024

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jun 23, 2024
@mchangir
Copy link
Contributor Author

mchangir commented Aug 9, 2024

reopening PR

@mchangir mchangir reopened this Aug 9, 2024
@mchangir mchangir force-pushed the mgr-snap_schedule-handle-volume-delete branch from 9e9025a to e2cd55e Compare August 9, 2024 08:14
@mchangir
Copy link
Contributor Author

mchangir commented Aug 9, 2024

rebased

@github-actions github-actions bot removed the stale label Aug 9, 2024
vshankar
vshankar reviewed Oct 30, 2024
View reviewed changes
vshankar
vshankar reviewed Oct 30, 2024
View reviewed changes
@mchangir
mgr/snap_schedule: handle volume delete
4d2af0c 
Remove references to timers and db connection that refer to paths in the
deleted volume.

This is a best case effort and not 100% safe. There can be race
conditions where the db connection is closed while the module is
executing a query on the db while the volume itself is deleted.

Hopefully there won't be many tracebacks seen.

Fixes: https://tracker.ceph.com/issues/63999
Signed-off-by: Milind Changire <[email protected]>
@mchangir
doc/cephfs: note about volume deletion affecting snap-schedule Manage…
153a698 
…r module

Signed-off-by: Milind Changire <[email protected]>
@mchangir mchangir force-pushed the mgr-snap_schedule-handle-volume-delete branch from e2cd55e to dd0c816 Compare November 4, 2024 16:10
@mchangir mchangir requested a review from a team as a code owner November 4, 2024 16:10
@vshankar
Copy link
Contributor

vshankar commented Nov 5, 2024

jenkins test make check

@vshankar vshankar self-assigned this Nov 5, 2024
@vshankar
Copy link
Contributor

vshankar commented Nov 12, 2024

jenkins test make check

vshankar
vshankar approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchangir please run this through QA testing.

@vshankar
Copy link
Contributor

vshankar commented Nov 18, 2024

This PR is under test in https://tracker.ceph.com/issues/68968.

vshankar added a commit to vshankar/ceph that referenced this pull request Nov 20, 2024
@vshankar
Merge PR ceph#55145 into wip-vshankar-testing-20241118.055430-debug
e73fdf1 
* refs/pull/55145/head:
	mon: emit warning during fs rm
	mgr/volumes: warn about active snap-schedules when volume is deleted
	doc/cephfs: note about volume deletion affecting snap-schedule Manager module
	mgr/snap_schedule: handle volume delete

Reviewed-by: Venky Shankar <[email protected]>
vshankar added a commit to vshankar/ceph that referenced this pull request Nov 29, 2024
@vshankar
Merge PR ceph#55145 into wip-vshankar-testing-20241129.105255-debug
5280d64 
* refs/pull/55145/head:
	mon: emit warning during fs rm
	mgr/volumes: warn about active snap-schedules when volume is deleted
	doc/cephfs: note about volume deletion affecting snap-schedule Manager module
	mgr/snap_schedule: handle volume delete

Reviewed-by: Venky Shankar <[email protected]>
vshankar
vshankar approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20241219063429-debug

@vshankar vshankar merged commit 56bc82b into ceph:main Dec 26, 2024
This was referenced Dec 26, 2024
Closed
Merged
Closed
@joscollin joscollin mentioned this pull request Oct 16, 2025
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

Assignees

@vshankar vshankar

Labels

cephfs Ceph File System core documentation mon needs-review pybind

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mchangir @vshankar