Skip to content

Comments

src/rgw: Adding null version id support#53850

Closed
TRYTOBE8TME wants to merge 2 commits intoceph:mainfrom
TRYTOBE8TME:wip-rgw-delete-obj-bug-trial
Closed

src/rgw: Adding null version id support#53850
TRYTOBE8TME wants to merge 2 commits intoceph:mainfrom
TRYTOBE8TME:wip-rgw-delete-obj-bug-trial

Conversation

@TRYTOBE8TME
Copy link

@TRYTOBE8TME TRYTOBE8TME commented Oct 5, 2023 •
edited by smanjara
Loading

https://tracker.ceph.com/issues/55179

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@TRYTOBE8TME TRYTOBE8TME force-pushed the wip-rgw-delete-obj-bug-trial branch from 57c8ee9 to 18d854f Compare November 1, 2023 06:42
@TRYTOBE8TME TRYTOBE8TME force-pushed the wip-rgw-delete-obj-bug-trial branch 2 times, most recently from af04e9a to 0e0e8fa Compare November 23, 2023 05:47
@TRYTOBE8TME TRYTOBE8TME force-pushed the wip-rgw-delete-obj-bug-trial branch 3 times, most recently from 2ca34ff to 92f7ce4 Compare December 14, 2023 00:20
@TRYTOBE8TME TRYTOBE8TME marked this pull request as ready for review January 1, 2024 12:00
@TRYTOBE8TME TRYTOBE8TME requested a review from a team as a code owner January 1, 2024 12:00
@TRYTOBE8TME
Copy link
Author

TRYTOBE8TME commented Jan 1, 2024

Still working on adding test cases. Will update soon.

@TRYTOBE8TME TRYTOBE8TME requested a review from smanjara January 1, 2024 12:01
@github-actions
Copy link

github-actions bot commented Jan 18, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@smanjara
Copy link
Contributor

smanjara commented Jan 18, 2024 •
edited
Loading

the commits could be squashed into a single one or into multiple ones with meaningful commit messages.

also, as discussed, we may not have to introduce a new variable in the rgw_bi_log_entry if we add a flag. we already have bilog_flags that we could make use of. this avoids the cls encode/decode changes.
I have an experimental branch here de71f4f which has this alternative version that extends bilog_flags, but I haven't been able to test it. Would you mind taking a look? Mostly everything remains the same. we just don't encode anything.

@TRYTOBE8TME
Copy link
Author

TRYTOBE8TME commented Jan 18, 2024

the commits could be squashed into a single one or into multiple ones with meaningful commit messages.

also, as discussed, we may not have to introduce a new variable in the rgw_bi_log_entry if we add a flag. we already have bilog_flags that we could make use of. this avoids the cls encode/decode changes. I have an experimental branch here de71f4f which has this alternative version that extends bilog_flags, but I haven't been able to test it. Would you mind taking a look? Mostly everything remains the same. we just don't encode anything.

Sure, I'll squash the commits into one and I'll test your branch as well. Thanks for this!

@cbodley
Copy link
Contributor

cbodley commented Jan 22, 2024

what bug is this fixing? i don't see any commit messages or tracker/bz links

@smanjara
Copy link
Contributor

smanjara commented Jan 22, 2024

what bug is this fixing? i don't see any commit messages or tracker/bz links

this is supposed to be bz#1967576 and tracker#55179

@TRYTOBE8TME TRYTOBE8TME force-pushed the wip-rgw-delete-obj-bug-trial branch 2 times, most recently from cffb4ff to d6163eb Compare February 8, 2024 07:20
@TRYTOBE8TME TRYTOBE8TME force-pushed the wip-rgw-delete-obj-bug-trial branch 2 times, most recently from 764b5ea to 9305b21 Compare February 8, 2024 16:37
@TRYTOBE8TME TRYTOBE8TME force-pushed the wip-rgw-delete-obj-bug-trial branch from 9305b21 to 2bfb892 Compare March 12, 2024 15:21
@github-actions
Copy link

github-actions bot commented Mar 12, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

kapandya added 2 commits March 12, 2024 20:54
@kapandya
src/rgw: Adding null version id support
22967cf 
This PR fixes tracker ceph#55179 and bz #1967576.
I've also added a test which tests that whether the
object with 'null' version id is getting deleted
from secondary zone as well.

Signed-off-by: Kalpesh Pandya <[email protected]>
@kapandya
src/rgw: Versioned object not getting deleted changes
1d835f6 
Reverting some changes that includes null_verid instead of bilog_flags

Signed-off-by: Kalpesh Pandya <[email protected]>
@TRYTOBE8TME TRYTOBE8TME force-pushed the wip-rgw-delete-obj-bug-trial branch from 2bfb892 to 1d835f6 Compare March 12, 2024 15:33
@github-actions
Copy link

github-actions bot commented May 11, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 11, 2024
@github-actions
Copy link

github-actions bot commented May 31, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@mattbenjamin
Copy link
Contributor

mattbenjamin commented May 31, 2024

@kapandya @smanjara can this make progress soon?

@github-actions github-actions bot removed the stale label May 31, 2024
@smanjara
Copy link
Contributor

smanjara commented Jun 12, 2024

@TRYTOBE8TME I have rebased and updated my branch wip-shilpa-null-version with a working version of this. I tested some basic cases and they work for me. Can you take a look? You could pull my changes into this one or open a new PR. upto you.

@TRYTOBE8TME
Copy link
Author

TRYTOBE8TME commented Jun 13, 2024

@TRYTOBE8TME I have rebased and updated my branch wip-shilpa-null-version with a working version of this. I tested some basic cases and they work for me. Can you take a look? You could pull my changes into this one or open a new PR. upto you.

On it, will update soon!

@smanjara smanjara mentioned this pull request Jun 19, 2024
Merged
14 tasks
@smanjara smanjara closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smanjara smanjara Awaiting requested review from smanjara

Assignees

No one assigned

Labels

needs-rebase rgw tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TRYTOBE8TME @smanjara @cbodley @mattbenjamin @kapandya