Skip to content

Comments

rgw: fix radosgw-admin bucket check stat calculation bug#53607

Merged
cbodley merged 3 commits intoceph:mainfrom
cfsnyder:wip-cfsnyder-bucket-check-bug
Sep 27, 2023
Merged

rgw: fix radosgw-admin bucket check stat calculation bug#53607
cbodley merged 3 commits intoceph:mainfrom
cfsnyder:wip-cfsnyder-bucket-check-bug

Conversation

@cfsnyder
Copy link
Contributor

@cfsnyder cfsnyder commented Sep 22, 2023

Fixes a regression with radosgw-admin bucket check stat
calculation and bucket reshard stat calculation when
there are objects that have transitioned from unversioned
to versioned. The bug was introduced in 152aadb.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@cfsnyder
rgw: add test case to reproduce bucket check stats bug for versioned …
340522f 
…bucket

Reproduces a regression where radosgw-admin bucket check incorrectly counts
objects that started as unversioned and later transitioned to versioned.

Signed-off-by: Cory Snyder <[email protected]>
@cfsnyder
rgw: fix radosgw-admin bucket check stat calculation bug
4728daa 
Fixes a regression with radosgw-admin bucket check stat
calculation and bucket reshard stat calculation when
there are objects that have transitioned from unversioned
to versioned. The bug was introduced in
152aadb.

Signed-off-by: Cory Snyder <[email protected]>
@cfsnyder cfsnyder requested a review from a team as a code owner September 22, 2023 21:18
@cfsnyder cfsnyder requested a review from cbodley September 22, 2023 21:19
@cfsnyder
Copy link
Contributor Author

cfsnyder commented Sep 22, 2023

I discovered this issue while working on a Pacific backport. I'll include these commits along with the others from #52576 when I submit that backport.

@cfsnyder
rgw: fix output formatting of bucket index check admin api
32fb6a1 
The bucket index check admin API was previously returning invalid
JSON.

Signed-off-by: Cory Snyder <[email protected]>
@cfsnyder cfsnyder mentioned this pull request Sep 25, 2023
Merged
14 tasks
@cfsnyder
Copy link
Contributor Author

cfsnyder commented Sep 25, 2023

This ragweed fix is associated with the fix for the admin bucket check api output format: ceph/ragweed#27

@cfsnyder
Copy link
Contributor Author

cfsnyder commented Sep 25, 2023

jenkins test api

cbodley
cbodley approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfsnyder do we need a separate tracker issue for the backports? or just include this with https://tracker.ceph.com/issues/61359 and/or https://tracker.ceph.com/issues/62075?

@cfsnyder
Copy link
Contributor Author

cfsnyder commented Sep 25, 2023

@cfsnyder do we need a separate tracker issue for the backports? or just include this with https://tracker.ceph.com/issues/61359 and/or https://tracker.ceph.com/issues/62075?

I was just going to include them with https://tracker.ceph.com/issues/62075 if that's ok with you

@cfsnyder
Copy link
Contributor Author

cfsnyder commented Sep 26, 2023

test results: https://pulpito.ceph.com/cfsnyder-2023-09-26_09:08:04-rgw-wip-cfsnyder-53607-distro-default-smithi/

@cfsnyder
Copy link
Contributor Author

cfsnyder commented Sep 26, 2023

looks like test failures are unrelated

@cbodley cbodley merged commit de55616 into ceph:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

No one assigned

Labels

needs-qa rgw tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cfsnyder @cbodley