Skip to content

Comments

RGW: Solving the issue of not populating etag in Multipart upload result#50627

Merged
AliMasarweh merged 1 commit intoceph:mainfrom
AliMasarweh:wip-ali-masa-multipart-populate-etag
May 10, 2023
Merged

RGW: Solving the issue of not populating etag in Multipart upload result#50627
AliMasarweh merged 1 commit intoceph:mainfrom
AliMasarweh:wip-ali-masa-multipart-populate-etag

Conversation

@AliMasarweh
Copy link
Member

@AliMasarweh AliMasarweh commented Mar 22, 2023

Solving the issue of not populating etag in Multipart upload result
https://tracker.ceph.com/issues/58879

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@AliMasarweh AliMasarweh requested a review from a team as a code owner March 22, 2023 13:44
@github-actions github-actions bot added the rgw label Mar 22, 2023
@AliMasarweh AliMasarweh changed the title RGW: Solving the issue of not populating etag in Multipart update result RGW: Solving the issue of not populating etag in Multipart upload result Mar 22, 2023
@dang
Copy link
Contributor

dang commented Mar 22, 2023

I forgot to mention that all Ceph commits need to be signed off. This is done with the "-s" option to "git commit". You can fix this in this commit with:
git commit -s --amend
And then save the commit message unchanged. Then force push ("git push -f") the branch again.

@AliMasarweh AliMasarweh force-pushed the wip-ali-masa-multipart-populate-etag branch from 7b4ce15 to 2b13cd9 Compare March 23, 2023 09:22
@AliMasarweh
Copy link
Member Author

Signed the commit and pushed again

@cbodley
Copy link
Contributor

cbodley commented Apr 3, 2023

there's a qa/workunits/rgw/run-s3tests.sh script that you can run from your ceph build directory. it will clone the https://github.com/ceph/s3-tests repo and run the subset of test cases that we expect to pass

you can add a test case for this fix to https://github.com/ceph/s3-tests/blob/master/s3tests_boto3/functional/test_s3.py

@alimaredia
Copy link
Contributor

@cbodley in teuthology should @AliMasarweh just be running just the rgw:verify suite with a revised s3-tests for this fix?

@cbodley
Copy link
Contributor

cbodley commented Apr 3, 2023

@cbodley in teuthology should @AliMasarweh just be running just the rgw:verify suite with a revised s3-tests for this fix?

the full rgw suite against revised s3-tests please

@cbodley
Copy link
Contributor

cbodley commented May 11, 2023

@AliMasarweh can you please share the teuthology results?

@cbodley
Copy link
Contributor

cbodley commented May 11, 2023

and is there an associated s3test case that needs to merge also?

@AliMasarweh
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants