cmake: s/HAVE_MSGHDR/WITH_SYSTEMD/#40658
Merged
tchaikov merged 2 commits intoceph:masterfrom Apr 12, 2021
Merged
Conversation
3 tasks
as FreeBSD also has msghdr but it does not have systemd, or flags like MFD_ALLOW_SEALING, O_TMPFILE or F_SEAL_GROW. so use WITH_SYSTEMD for enabling journald backend of logging system. also move the option of "WITH_SYSTEMD" up so that the src/CMakeLists.txt is able to see the variable of WITH_SYSTEMD defined by it. Signed-off-by: Kefu Chai <[email protected]>
as FreeBSD does not has systemd at the time of writing, so it does not make sense to build or install systemd support. Signed-off-by: Kefu Chai <[email protected]>
wjwithagen
approved these changes
Apr 8, 2021
Contributor
wjwithagen
left a comment
wjwithagen
left a comment
There was a problem hiding this comment.
Jenkins build is back to normal : ceph-master-compile #6416
Contributor
Author
|
Contributor
Author
|
jenkins test make check |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox