[DNM] cephadm: Has the podman journald log driver a problem with line breaks?#39547
Closed
sebastian-philipp wants to merge 1 commit intoceph:masterfrom
Closed
[DNM] cephadm: Has the podman journald log driver a problem with line breaks?#39547sebastian-philipp wants to merge 1 commit intoceph:masterfrom
sebastian-philipp wants to merge 1 commit intoceph:masterfrom
Conversation
… breaks? Revert "cephadm: configure journald as the logdriver" This reverts commit 7c44f21.
Contributor
Author
|
let's see if this is related to this strange logging behavior: |
Contributor
Author
|
with this PR, the output looks like so: and that's all we get from journald. Thus the messages that are broken in the logs are completely gone otherwise!: Without this PR, the output looks like so: |
Contributor
|
I see the same behavior too. This may because ceph daemon issues multiple write system calls for a single line of log. And conmon does not buffer until a newline. Can we enable ceph daemons to talk to journald directly? We can take advantage of journald structured log. e.g.:
I would like to contribute if this idea looks good. |
3 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "cephadm: configure journald as the logdriver"
This reverts commit 7c44f21.
Details: https://tracker.ceph.com/issues/49551
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox