Fix: Local runtime upgrade scripts #1308
Conversation
wischli
added
D0-ready
scripts/js/upgrade/index.js
Outdated
| const util = require('util'); | ||
| const exec = util.promisify(require('child_process').exec); | ||
|
|
||
| const PREIMAGE_LENGTH_BOUND = 34; |
There was a problem hiding this comment.
How are these values obtained or updatable based on what in the future?
There was a problem hiding this comment.
I.e, are these values always the same for any pre-image proposing authorising a runtime upgrade? Or do we need to keep changing them? If so, what's the best way to do that? I am 90% we don't, but just want to double check.
There was a problem hiding this comment.
I will definitely improve the name to something like AUTHORIZE_UPGRADE_PREIMAGE_LENGTH_BOUND. Regarding the value itself: The WASM code of authorize_upgrade(code) is hashed with H256 which encoded to 32 bytes. I remember to have tried with 32 as bound as well and failed, so I suppose the other two are some wrapper bytes.
NunoAlexandre
left a comment
NunoAlexandre
left a comment
There was a problem hiding this comment.
My question is not a blocker, if you have tested these changes and the code looks fine so it's good to go for me.
scripts/js/upgrade/index.js
Outdated
| // 39 from edemocracy.xternalProposeMajority(Lookup(H256, 34))) | ||
| // 42 from democracy.fastTrack(H256, ...) | ||
| // 1 from utility.batchAll | ||
| // 2 extra |
There was a problem hiding this comment.
I guess the "2 extra" bytes is the first for the pallet index and the second for the extrinsic index?
scripts/js/upgrade/index.js
Outdated
| // Needs to be >= 34 | ||
| // 32 bytes from the encoding of the H256 hashed WASM blob | ||
| // 2 for extra stuff | ||
| const AUTHORIZE_UPGRADE_PREIMAGE_LENGTH_BOUND = 34; |
There was a problem hiding this comment.
Leaving this one here and I feel this is really something missing in the polkadot dev ecosystem: https://ruudvanasseldonk.com/2022/03/20/please-put-units-in-names
NunoAlexandre
left a comment
NunoAlexandre
left a comment
There was a problem hiding this comment.
Left a nugget but again not a blocker for me. Thanks for fixing this and taking the suggestions in 🏄♂️
Description
./scripts/jsto latest version, reducing peer dependency spam in the consolePreImagepallet in Update polkadot v0.9.32 #1115 as a result of Bound uses ofCallparitytech/substrate#11649proofSizein weights v2How to test
Checklist: