This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add explicit reference for status code strings#97
Merged
semistrict merged 1 commit intocensus-instrumentation:masterfrom Apr 11, 2018
Merged
Add explicit reference for status code strings#97semistrict merged 1 commit intocensus-instrumentation:masterfrom
semistrict merged 1 commit intocensus-instrumentation:masterfrom
Conversation
semistrict
force-pushed
the
status-code-strings
branch
from
daab1ce to
7b31b31
Compare
sebright2
reviewed
Apr 10, 2018
| `grpc_client_status` is set when an outgoing request finishes and is only available around metrics | ||
| recorded at the end of the outgoing request. | ||
| Status codes should be stringified according to: | ||
| https://github.com/grpc/grpc/blob/ee6e4dc/doc/statuscodes.md |
Contributor
There was a problem hiding this comment.
Is there a way to link to the latest status code documentation? That might be better than a specific commit, since the description could be updated.
Contributor
Author
There was a problem hiding this comment.
Pointed to master
semistrict
force-pushed
the
status-code-strings
branch
from
7b31b31 to
979a3de
Compare
sebright2
approved these changes
Apr 10, 2018
bogdandrutu
reviewed
Apr 10, 2018
| `grpc_server_status` is set when an incoming request finishes and is only available around metrics | ||
| recorded at the end of the incoming request. | ||
| Status codes should be stringified according to: | ||
| https://github.com/grpc/grpc/blob/master/doc/statuscodes.md |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I considered that, but since this document is all about gRPC I think it's better to point to gRPC docs.
bogdandrutu
approved these changes
Apr 11, 2018
semistrict
force-pushed
the
status-code-strings
branch
from
979a3de to
b5ad53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.