This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add gRPC metrics that allow real-time reporting.#212
Merged
songy23 merged 4 commits intocensus-instrumentation:masterfrom Nov 19, 2018
Merged
Add gRPC metrics that allow real-time reporting.#212songy23 merged 4 commits intocensus-instrumentation:masterfrom
songy23 merged 4 commits intocensus-instrumentation:masterfrom
Conversation
For streaming RPCs, especially long-lived ones, we want to have stats for each message as it is sent/received, rather than waiting until the end of the RPC to record stats.
songy23
force-pushed
the
grpc-streaming-stats
branch
from
05136a3 to
87e5546
Compare
zhangkun83
approved these changes
Nov 16, 2018
| | grpc.io/client/started_rpcs | 1 | The total number of client RPCs ever opened, including those that have not completed. | | ||
| | grpc.io/client/sent_messages_per_method | 1 | Total messages sent per method. | | ||
| | grpc.io/client/received_messages_per_method | 1 | Total messages received per method. | | ||
| | grpc.io/client/sent_bytes_per_method | By | Total bytes sent per method, recorded for each message. | |
There was a problem hiding this comment.
Not necessarily recorded for each message. Maybe "recorded real-time as bytes are sent".
songy23
force-pushed
the
grpc-streaming-stats
branch
from
e1df38f to
6e2dc68
Compare
songy23
changed the title
songy23
force-pushed
the
grpc-streaming-stats
branch
from
6e2dc68 to
709ecc4
Compare
Contributor
Author
|
PTAL @bogdandrutu |
bogdandrutu
reviewed
Nov 19, 2018
| | grpc.io/client/roundtrip_latency | grpc.io/client/roundtrip_latency | distribution | grpc_client_method | | ||
| | grpc.io/client/completed_rpcs | grpc.io/client/roundtrip_latency | count | grpc_client_method, grpc_client_status | | ||
| | grpc.io/client/started_rpcs | grpc.io/client/started_rpcs | count | grpc_client_method | | ||
| | grpc.io/client/sent_messages_per_method | grpc.io/client/sent_messages_per_method | count | grpc_client_method | |
Contributor
There was a problem hiding this comment.
I don't think this are necessary in the default views. I would put them in the extra views for the moment. We probably want to have these measurements not enabled by default to avoid unnecessary overhead for unary calls (probably the majority of the calls).
Contributor
Author
There was a problem hiding this comment.
Yes I agree. Made them optional for the moment, and add an FAQ about these views.
bogdandrutu
approved these changes
Nov 19, 2018
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #206.
Use plain accumulations for streaming bytes and message counts. We won't be able to associate wire bytes with messages with stream-based compression.