This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add RPC constants started_rpcs.#120
Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom Jun 4, 2018
Merged
Conversation
songy23
requested review from
bogdandrutu,
dinooliva,
sebright2,
semistrict and
zhangkun83
semistrict
approved these changes
Jun 4, 2018
zhangkun83
reviewed
Jun 4, 2018
| | grpc.io/client/received_bytes_per_rpc | grpc.io/client/received_bytes_per_rpc | distribution | grpc_client_method | | ||
| | grpc.io/client/roundtrip_latency | grpc.io/client/roundtrip_latency | distribution | grpc_client_method | | ||
| | grpc.io/client/completed_rpcs | grpc.io/client/roundtrip_latency | count | grpc_client_method, grpc_client_status | | ||
| | grpc.io/client/started_rpcs | grpc.io/client/started_rpcs | count | grpc_client_method, grpc_client_status | |
There was a problem hiding this comment.
Status should not be exposed by started counts.
| | grpc.io/server/sent_bytes_per_rpc | grpc.io/server/sent_bytes_per_rpc | distribution | grpc_server_method | | ||
| | grpc.io/server/server_latency | grpc.io/server/server_latency | distribution | grpc_server_method | | ||
| | grpc.io/server/completed_rpcs | grpc.io/server/server_latency | count | grpc_server_method, grpc_server_status | | ||
| | grpc.io/server/started_rpcs | grpc.io/server/started_rpcs | count | grpc_server_method, grpc_server_status | |
Contributor
Author
|
Going to merge this PR by EOD today if there are no further concerns/questions. Thanks for review! |
bogdandrutu
approved these changes
Jun 4, 2018
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
started_rpcsis required by gRPC and is not covered by our current constants. See https://github.com/grpc/grpc-java/pull/4494/files#r191610513.