This repository was archived by the owner on Sep 17, 2025. It is now read-only.
fix typename data drop#1234
Merged
lzchen merged 1 commit intocensus-instrumentation:masterfrom Nov 20, 2023
Merged
Conversation
jeremydvoss
requested review from
a team,
aabmass,
hectorhdzg and
lzchen
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jeremydvoss
force-pushed
the
fastapi-datadrop
branch
from
6477f27 to
6551102
Compare
Contributor
|
Can we add a test for this? Also looks like you need to sign the CLA |
lzchen
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using FastAPI's HTTPException, ERROR_NAME cannot be pulled from the exception by the trace exporter. Defaulting to 'Exception'.