Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Comments

Include version.py in distribution for certain packages#1143

Merged
lzchen merged 11 commits intocensus-instrumentation:masterfrom
lzchen:version
Aug 2, 2022
Merged

Include version.py in distribution for certain packages#1143
lzchen merged 11 commits intocensus-instrumentation:masterfrom
lzchen:version

Conversation

@lzchen
Copy link
Contributor

@lzchen lzchen commented Jul 29, 2022 •
edited
Loading

Applies to:

opencensus-context
opencensus-ext-flask
opencensus-ext-requests

specifically requested by a user.

@lzchen lzchen requested review from a team, aabmass, hectorhdzg and songy23 as code owners July 29, 2022 23:01
aabmass
aabmass reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think `context/opencensus-context/opencensus/common/version.py may conflict with this package https://github.com/census-instrumentation/opencensus-python/blob/master/opencensus/common/version/__init__.py?

Wouldn't they existin the same namespace package?

@lzchen
Copy link
Contributor Author

lzchen commented Aug 2, 2022 •
edited
Loading

@aabmass

I think `context/opencensus-context/opencensus/common/version.py may conflict with this package https://github.com/census-instrumentation/opencensus-python/blob/master/opencensus/common/version/__init__.py?

I moved context/opencensus-context/opencensus/common/version.py to context/opencensus-context/opencensus/common/runtime_context/version.py. This way it would be more clear that the version.py belongs to the context package when going through the namespace packages.

@lzchen lzchen merged commit 9880318 into census-instrumentation:master Aug 2, 2022
@lzchen lzchen deleted the version branch August 2, 2022 18:11
@lzchen lzchen mentioned this pull request Aug 3, 2022
Merged
@lzchen lzchen added the azure Microsoft Azure label Nov 9, 2022
inirudebwoy pushed a commit to inirudebwoy/opencensus-python that referenced this pull request Jan 11, 2023
@lzchen @inirudebwoy
Include version.py in distribution for certain packages (census-instr…
a8240a6 
…umentation#1143)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

@songy23 songy23 Awaiting requested review from songy23

1 more reviewer

@aabmass aabmass aabmass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

azure Microsoft Azure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lzchen @aabmass