This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add kwargs to derived gauge#1135
Merged
lzchen merged 2 commits intocensus-instrumentation:masterfrom Jun 30, 2022
Merged
Conversation
lzchen
requested review from
a team,
aabmass,
hectorhdzg and
songy23
as code owners
aabmass
reviewed
Jun 30, 2022
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
What does this PR do? I'm not very familiar with this code. It looks like it's unconditionally adding kwargs as labels for the DerivedGauge?
Contributor
Author
inirudebwoy
pushed a commit
to inirudebwoy/opencensus-python
that referenced
this pull request
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.