This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Azure: Allow specifying metrics for custom events#1117
Merged
lzchen merged 1 commit intocensus-instrumentation:masterfrom Apr 21, 2022
Merged
Azure: Allow specifying metrics for custom events#1117lzchen merged 1 commit intocensus-instrumentation:masterfrom
lzchen merged 1 commit intocensus-instrumentation:masterfrom
Conversation
Davi-DeGanne
requested review from
a team,
aabmass,
hectorhdzg,
lzchen and
songy23
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Davi-DeGanne
force-pushed
the
event-measurements
branch
from
12e7e82 to
325bdaf
Compare
lzchen
reviewed
Apr 15, 2022
contrib/opencensus-ext-azure/opencensus/ext/azure/log_exporter/__init__.py
Show resolved
Hide resolved
Contributor
|
Please add a CHANGELOG entry. |
Contributor
|
If you rebase, I believe the build errors will be fixed. |
Davi-DeGanne
force-pushed
the
event-measurements
branch
from
325bdaf to
9b1fa95
Compare
Contributor
Author
|
@lzchen Ok, how does this look? |
lzchen
reviewed
Apr 20, 2022
Davi-DeGanne
force-pushed
the
event-measurements
branch
from
9b1fa95 to
6fdac32
Compare
lzchen
approved these changes
Apr 21, 2022
inirudebwoy
pushed a commit
to inirudebwoy/opencensus-python
that referenced
this pull request
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to specify custom measurements as part of Azure events, emulating the way it was done for custom dimensions.
Testing
I tested this manually using the following python command:
My Application Insights resource successfully received a custom event with both the
customDimensionsandcustomMeasurementsproperties.Additional Context
This was requested in a comment in #809 and this PR might be the final piece needed to close that issue, but I'm not sure because the feature request made there isn't very specific.