Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Deprecated measures use instance of new measures when 1to1 mapping. …#1740

Merged
bogdandrutu merged 1 commit intocensus-instrumentation:v0.19.xfrom
songy23:v0.19.x
Feb 6, 2019
Merged

Deprecated measures use instance of new measures when 1to1 mapping. …#1740
bogdandrutu merged 1 commit intocensus-instrumentation:v0.19.xfrom
songy23:v0.19.x

Conversation

@songy23
Copy link
Copy Markdown
Contributor

@songy23 songy23 commented Feb 6, 2019

…(#1738)

  • Move deprecated measures after non-deprecated once.

  • Deprecated measures use instance of new measures when 1to1 mapping.

  • Run java format.

  • Remove installation of the old views in grpc basic view.

  • Fix RpcViewTests.

(cherry picked from commit 5d85e9e)

…ensus-instrumentation#1738)

* Move deprecated measures after non-deprecated once.

* Deprecated measures use instance of new measures when 1to1 mapping.

* Run java format.

* Remove installation of the old views in grpc basic view.

* Fix RpcViewTests.

(cherry picked from commit 5d85e9e)
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 6, 2019

Codecov Report

Merging #1740 into v0.19.x will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             v0.19.x    #1740      +/-   ##
=============================================
- Coverage      82.01%   81.97%   -0.04%     
  Complexity      1904     1904              
=============================================
  Files            280      280              
  Lines           8940     8927      -13     
  Branches         851      851              
=============================================
- Hits            7332     7318      -14     
  Misses          1326     1326              
- Partials         282      283       +1
Impacted Files Coverage Δ Complexity Δ
...a/io/opencensus/contrib/grpc/metrics/RpcViews.java 71.83% <100%> (ø) 18 <2> (ø) ⬇️
...nsus/contrib/grpc/metrics/RpcMeasureConstants.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...census/implcore/trace/export/SpanExporterImpl.java 95.89% <0%> (-1.37%) 9% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18db12d...b5be40c. Read the comment docs.

@songy23
Copy link
Copy Markdown
Contributor Author

songy23 commented Feb 6, 2019

Holding off this PR a bit to also pick up #1741.

@bogdandrutu bogdandrutu merged commit 8e3fb61 into census-instrumentation:v0.19.x Feb 6, 2019
@bogdandrutu
Copy link
Copy Markdown
Contributor

Better to do it in a separate PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants