This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Deprecated measures use instance of new measures when 1to1 mapping.#1738
Merged
bogdandrutu merged 5 commits intocensus-instrumentation:masterfrom Feb 6, 2019
Merged
Conversation
Contributor
Author
|
To see what changed look at this babf3d3 or the second commit. |
songy23
approved these changes
Feb 6, 2019
Contributor
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
Please run Java formatter.
Contributor
Author
|
One more change - removed the old views from the grpc basic views. This method never worked because of the duplicated measure name so this is not a problem. |
songy23
reviewed
Feb 6, 2019
|
|
||
| @VisibleForTesting | ||
| static final ImmutableSet<View> RPC_REAL_TIME_METRICS_VIEWS_SET = | ||
| static final ImmutableSet<View> GRPC_REAL_TIME_METRICS_VIEWS_SET = |
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 82.12% 82.07% -0.05%
Complexity 1950 1950
============================================
Files 288 288
Lines 9061 9048 -13
Branches 862 862
============================================
- Hits 7441 7426 -15
- Misses 1329 1331 +2
Partials 291 291
Continue to review full report at Codecov.
|
songy23
approved these changes
Feb 6, 2019
dinooliva
approved these changes
Feb 6, 2019
songy23
pushed a commit
to songy23/instrumentation-java
that referenced
this pull request
Feb 6, 2019
…ensus-instrumentation#1738) * Move deprecated measures after non-deprecated once. * Deprecated measures use instance of new measures when 1to1 mapping. * Run java format. * Remove installation of the old views in grpc basic view. * Fix RpcViewTests. (cherry picked from commit 5d85e9e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intentionally split this into 2 commits to make it easy to see the changes, first commit just moves the code of deprecated measures after the new measures, second commit actually does the main change.
This fixes an issue with registerAllGrpcBasicViews because we had 2 measures (rountrip_latency) with different descriptions and this will fail here https://github.com/census-instrumentation/opencensus-java/blob/master/impl_core/src/main/java/io/opencensus/implcore/stats/MeasureToViewMap.java#L115
This is a breaking change in regard to the measure name/description for the old measures, but nobody should depend on that.