Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Fix issues in RPC constants#1118

Merged
songy23 merged 6 commits intocensus-instrumentation:masterfrom
songy23:rpc-constants
Apr 10, 2018
Merged

Fix issues in RPC constants#1118
songy23 merged 6 commits intocensus-instrumentation:masterfrom
songy23:rpc-constants

Conversation

@songy23
Copy link
Copy Markdown
Contributor

@songy23 songy23 commented Apr 10, 2018

As a follow up for #1115.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 10, 2018

Codecov Report

Merging #1118 into master will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1118      +/-   ##
============================================
- Coverage     81.99%   81.98%   -0.02%     
  Complexity     1213     1213              
============================================
  Files           188      188              
  Lines          5821     5817       -4     
  Branches        523      523              
============================================
- Hits           4773     4769       -4     
  Misses          905      905              
  Partials        143      143
Impacted Files Coverage Δ Complexity Δ
...nsus/contrib/grpc/metrics/RpcMeasureConstants.java 98.63% <ø> (-0.08%) 1 <0> (ø)
...a/io/opencensus/contrib/grpc/metrics/RpcViews.java 70% <0%> (ø) 8 <0> (ø) ⬇️
...ncensus/contrib/grpc/metrics/RpcViewConstants.java 99.72% <100%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb53c02...ab84dea. Read the comment docs.

@sebright2 sebright2 assigned songy23 and unassigned sebright2 Apr 10, 2018
@songy23
Copy link
Copy Markdown
Contributor Author

songy23 commented Apr 10, 2018

Thanks!

@songy23 songy23 merged commit 10927ff into census-instrumentation:master Apr 10, 2018
@songy23 songy23 deleted the rpc-constants branch May 2, 2018 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants