This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Don't propagate method and canonical_status for gRPC requests#566
Merged
rakyll merged 1 commit intocensus-instrumentation:masterfrom Mar 13, 2018
Merged
Don't propagate method and canonical_status for gRPC requests#566rakyll merged 1 commit intocensus-instrumentation:masterfrom
rakyll merged 1 commit intocensus-instrumentation:masterfrom
Conversation
These tags should be created at the node and applied when recording measurements. They shouldn't be propagated. Fixes census-instrumentation#541.
semistrict
approved these changes
Mar 12, 2018
odeke-em
reviewed
Mar 13, 2018
| tag.Upsert(KeyMethod, methodName(fullinfo)), | ||
| func (h *ServerHandler) createTags(ctx context.Context) (context.Context, error) { | ||
| buf := stats.Tags(ctx) | ||
| if buf == nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tags should be created at the node and applied when recording
measurements. They shouldn't be propagated.
Fixes #541.