Make execute_trade atomic #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaBothara
approved these changes
Oct 12, 2020
aliXsed
pushed a commit
that referenced
this pull request
Oct 22, 2020
* update/2.0.0: Slashed CENNZ to treasury/reporter (#299) Update plug commit to get correct WeightInfo for prmls (#300) Bonding is enabled by default but can be blocked by root (#298) Chore/config runtime fee (#296) Config attestation in the runtime (#295) Add transaction payment rpc to cli (#294) Update/fix test build (#293) Update/2.0.0 staking update (#292) Make execute_trade atomic (#291) Update CENNZX (#287) Update/transaction payment (#290) Reinstate dev + nikau genesis builds (#289) Build Sylo modules and its tests and make the tests pass (#288) Fmt Undo WIP sylo changes Client compile and sync Cargo deps fixed Format CENNZX compiles [WIP] fixing cennzx # Conflicts: # runtime/src/impls.rs # runtime/src/lib.rs # runtime/tests/staking_reward.rs
aliXsed
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Update cennznet to be compatible with and use Plug 2.0 * Make execute_trade atomic (#291) * Remove contract tests * Bonding is enabled by default but can be blocked by root (#298) * Slashed CENNZ to treasury/reporter (#299) * Use negative imbalance with correct asset ID * Use automated slash and reported slash in tests * downgrade wabt version: paritytech/substrate#7042 * Ignore tests that are being worked on as part of the "configuring runtime v37" task Co-authored-by: Jordan Beauchamp <[email protected]> Co-authored-by: KarishmaBothara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents storage changes from persisting if something fails during intermediate operations (new feature in 2.0)