Use built-in unittest.mock and remove unneeded case dep#37
Closed
mgorny wants to merge 1 commit intocelery:masterfrom
Closed
Use built-in unittest.mock and remove unneeded case dep#37mgorny wants to merge 1 commit intocelery:masterfrom
mgorny wants to merge 1 commit intocelery:masterfrom
Conversation
Use the built-in unittest.mock module to implement mocks since Python 2 is no longer supported. Remove unused fixtures, and effectively the dependency on case package. It seems that this package has been pulling six implicitly for sphinx_celery, so add the transitional dep for the time being. See celery/sphinx_celery#11.
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 6 6
Lines 280 280
Branches 47 47
=======================================
Hits 260 260
Misses 16 16
Partials 4 4 Continue to review full report at Codecov.
|
auvipy
approved these changes
Apr 1, 2021
graingert
approved these changes
Jul 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the built-in unittest.mock module to implement mocks since Python 2
is no longer supported. Remove unused fixtures, and effectively
the dependency on case package.
It seems that this package has been pulling six implicitly for
sphinx_celery, so add the transitional dep for the time being.
See celery/sphinx_celery#11.