Merged
Conversation
six is used in two modules: sphinx_celery/apicheck.py:from six import string_types sphinx_celery/configcheck.py:from six import iterkeys as keys
mgorny
added a commit
to mgorny/vine
that referenced
this pull request
Apr 1, 2021
Use the built-in unittest.mock module to implement mocks since Python 2 is no longer supported. Remove unused fixtures, and effectively the dependency on case package. It seems that this package has been pulling six implicitly for sphinx_celery, so add the transitional dep for the time being. See celery/sphinx_celery#11.
auvipy
approved these changes
Apr 1, 2021
Member
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
adding for now. but we will have to drop py2 support in near future
auvipy
pushed a commit
to celery/vine
that referenced
this pull request
Jul 21, 2021
* Use built-in unittest.mock and remove unneeded case dep Use the built-in unittest.mock module to implement mocks since Python 2 is no longer supported. Remove unused fixtures, and effectively the dependency on case package. It seems that this package has been pulling six implicitly for sphinx_celery, so add the transitional dep for the time being. See celery/sphinx_celery#11. * enable pre-commit * use extend-ignore * use isort black profile * apply isort * manual flake8 fixes * apply yes-qa Co-authored-by: Michał Górny <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
six is used in two modules: