Conversation
|
good to see tests are passing |
|
I want to include it on 5.1 release, may be after christmas or on the new years |
|
|
|
@4383 as far i can recall you use this package on old openstack versions right? would love to have you try this changes |
matusvalo
left a comment
matusvalo
left a comment
There was a problem hiding this comment.
I don't see any benefit having __slots__ for classes except Message class. __slots__ is mainly performance related and the only class that is created on bigger scales is Message class.
|
IMHO, other classes when used in production, could be also benefited as well? |
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
I am merging this as I can see most of the classes are used by kombu and celery, so in bigger system tiny resource saving would be beneficial, IMHO
2 participants
will add more slots and fix the issues which break the CI
related celery/vine#67